From patchwork Mon Jun 7 15:50:21 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Deucher X-Patchwork-Id: 104786 Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o57FqLqa032113 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 7 Jun 2010 15:52:57 GMT Received: from localhost ([127.0.0.1] helo=sfs-ml-1.v29.ch3.sourceforge.com) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1OLeas-0006KU-Pb; Mon, 07 Jun 2010 15:50:30 +0000 Received: from sfi-mx-2.v28.ch3.sourceforge.com ([172.29.28.122] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1OLeaq-0006KJ-Rn for dri-devel@lists.sourceforge.net; Mon, 07 Jun 2010 15:50:28 +0000 Received-SPF: pass (sfi-mx-2.v28.ch3.sourceforge.com: domain of gmail.com designates 209.85.161.47 as permitted sender) client-ip=209.85.161.47; envelope-from=alexdeucher@gmail.com; helo=mail-fx0-f47.google.com; Received: from mail-fx0-f47.google.com ([209.85.161.47]) by sfi-mx-2.v28.ch3.sourceforge.com with esmtp (Exim 4.69) id 1OLeap-0000w7-OQ for dri-devel@lists.sourceforge.net; Mon, 07 Jun 2010 15:50:28 +0000 Received: by fxm9 with SMTP id 9so2482827fxm.34 for ; Mon, 07 Jun 2010 08:50:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.68.131 with SMTP id v3mr15282789fai.82.1275925821722; Mon, 07 Jun 2010 08:50:21 -0700 (PDT) Received: by 10.223.122.13 with HTTP; Mon, 7 Jun 2010 08:50:21 -0700 (PDT) In-Reply-To: References: <201006071129.32159.rjw@sisk.pl> Date: Mon, 7 Jun 2010 11:50:21 -0400 Message-ID: Subject: Re: [Regression, post-rc1] Multiple issues after enabling SetVoltage on rs780m From: Alex Deucher To: Dave Airlie X-Spam-Score: -0.8 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.0 SPF_PASS SPF: sender matches SPF record -0.0 DKIM_VERIFIED Domain Keys Identified Mail: signature passes verification 0.0 DKIM_SIGNED Domain Keys Identified Mail: message has a signature 0.8 AWL AWL: From: address is in the auto white-list X-Headers-End: 1OLeap-0000w7-OQ Cc: LKML , "Rafael J. Wysocki" , Dave Airlie , Andrew Morton , dri-devel@lists.sourceforge.net, Linus Torvalds X-BeenThere: dri-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.sourceforge.net X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Mon, 07 Jun 2010 15:52:57 +0000 (UTC) From 8c055a2a5c0bd063fe2bf4797c585fd1cd59a673 Mon Sep 17 00:00:00 2001 From: Alex Deucher Date: Mon, 7 Jun 2010 11:35:53 -0400 Subject: [PATCH] drm/radeon/kms/pm: Disable voltage adjust on RS780/RS880 The vddc value in the power tables is not an actual voltage like on discrete r6xx/r7xx/evergreen systems, but instead has a symbolic meaning (e.g., NONE, LOW, HIGH, etc.). See atombios.h Most RS780/RS880 vbioses don't have a SetVoltage table anyway, so it shouldn't be doing anything to the hardware at the moment. I need to figure out how voltage is supposed to work on the newer IGPs; until then, disable it. Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_atombios.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c index 0616e39..5dd86b9 100644 --- a/drivers/gpu/drm/radeon/radeon_atombios.c +++ b/drivers/gpu/drm/radeon/radeon_atombios.c @@ -1841,10 +1841,7 @@ void radeon_atombios_get_power_modes(struct radeon_device *rdev) /* skip invalid modes */ if (rdev->pm.power_state[state_index].clock_info[mode_index].sclk == 0) continue; - rdev->pm.power_state[state_index].clock_info[mode_index].voltage.type = - VOLTAGE_SW; - rdev->pm.power_state[state_index].clock_info[mode_index].voltage.voltage = - clock_info->usVDDC; + /* voltage works differently on IGPs */ mode_index++; } else if (ASIC_IS_DCE4(rdev)) { struct _ATOM_PPLIB_EVERGREEN_CLOCK_INFO *clock_info = -- 1.7.0.1