From patchwork Tue Feb 25 11:06:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 13989832 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F9FCC021B2 for ; Tue, 25 Feb 2025 11:06:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AE8DC10E4BA; Tue, 25 Feb 2025 11:06:12 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=live.com header.i=@live.com header.b="hGfoiBkx"; dkim-atps=neutral Received: from MA0PR01CU009.outbound.protection.outlook.com (mail-southindiaazolkn19010000.outbound.protection.outlook.com [52.103.67.0]) by gabe.freedesktop.org (Postfix) with ESMTPS id B9BD510E4BA for ; Tue, 25 Feb 2025 11:06:11 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BLZmS3CWN0QJB7m6gvc183PppIdGpnu8LFtkciamUMqOnbACSRt0PFVGHh5NxS1rM5chV05MkaONalm2slt3xMidkqxbTzn1Ib6KMqixuKX5xKfsIJl87dnwdHv04JFOSSTLk+/B6rG5sOvR4ofG0A+HuuKI0LgvQWRc/GhlFF6QW+6Od6N5f36Eyfxdb4cv6zDSeTdSO2bEgZ5KnAoItYY1cGh7YETiH9xYWRjOx+6uYFP6/+z7k7ArWbo0bfbj3NxGBkR8iaWNtYjlGI9FFp+aPq8J3dI4cjWr9yQgkLrVqI/Um790Yuckn1QZxceGvVW3p9DgYJIfb1OpFUuv4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yts9bZQAaO+R2LbWbBH9Nx3QMynqSGPgSj847sgTzmQ=; b=B9lG91Hzk+C9qSgm3uelYIdD3VONgygaDjo8RvJn8bE90spKGH6mDrmTSR38qrJGWuXuucysrmZpPObRmcdHKaKEuyXSDoLP0bV5gQ1Uh3UQTBT6MfdzQsqooG8gW3MB0nA94/4Hk4F3ho+mHwOEA1EEt5UgD6xIH7Ucdq6JEaUhsTXbh5lq5d8y5mHQIVjkJeMJX455muSVv6NCyJ6nQ9PpbXvBYrrjgYL6IxDyAjMGsopI8RrbVvdmI9k3O/eHoQg9IsSPlq6c6nPTpbQ1bnwM9ASOXkqB4zcm+tKCBIsWezGkE31HdjbVVIffsg2J0ewfa5LlzyTj0Sg6+7cV8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yts9bZQAaO+R2LbWbBH9Nx3QMynqSGPgSj847sgTzmQ=; b=hGfoiBkxEAu2hbarXPEPXOv216Lxd6wpJWZvkcqHEJGVO8iuMJZW0OkSaf9pShTeGnJtRkDy4mQf0+McnD2MDy+nR3aMMe/KNATQLzXgbfA2uYUfZ5QnCWstsXH00tqRrdHoCRPN65Bl0CO+Ww4SaWdpVfB/53v1zqrsJW8EJnd5XFeehazckBkAJUiGAykC6N3vnrG89nBL4vJQfX3DMkGRGmZvubBtLugwrTB/LP9SrK1SN+A7bhmIFP1flMmg5aAxaESS6Y+i7oTR7rG3IG75/KSEEHE2vbOfgsfymiX9PgNqEq0CVKrSM9tfrB1XptHWCw2vGEQqmoihaVFX5A== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by MAZPR01MB8050.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:83::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.23; Tue, 25 Feb 2025 11:06:03 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8466.016; Tue, 25 Feb 2025 11:06:02 +0000 From: Aditya Garg To: "airlied@redhat.com" , "tzimmermann@suse.de" , "jfalempe@redhat.com" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "airlied@gmail.com" , "simona@ffwll.ch" , "kraxel@redhat.com" , "javierm@redhat.com" CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux.dev" , "andriy.shevchenko@linux.intel.com" Subject: [PATCH 1/6] drm/ast: Remove redundant else in atomic_check Thread-Topic: [PATCH 1/6] drm/ast: Remove redundant else in atomic_check Thread-Index: AQHbh3VCVyNi4daYg0mU60+I+/4tfg== Date: Tue, 25 Feb 2025 11:06:02 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN3PR01MB9597:EE_|MAZPR01MB8050:EE_ x-ms-office365-filtering-correlation-id: e2628023-bf42-4f0b-fd8a-08dd558c64a2 x-microsoft-antispam: BCL:0; ARA:14566002|19110799003|8062599003|8060799006|7092599003|15080799006|12121999004|461199028|3412199025|440099028|41001999003|102099032; x-microsoft-antispam-message-info: I69wH3CbS8eDM+tJ+gSRo+djOarIcoCU3BVKhzs15HDSOE35doYhAzP9QNbzzeOwmc2S4ws6GxgXF2vyK5fxjcyT/CcyzXGQuC79cWrBdgY8mYEDdYYa+dbab6BvgihFAqZr3hv9Ankdm/0Cx2wH4sa2Cv6J0ueiCxMdWlVrHzUezqZ7LGrxrHqWMQANf/FKRftogJ5wrfu+CrlxGS8OVHoKIzBRUz/OBORuuS0h1Pe8L0+9E7tY+k9mhRF/7jHVMTAIvHtBfLEzrd6z1lTBbhG+/0ZYZxl+fZMkDCXlLRudg3zGEVOeZ2t7HIzmOo3ktIsNGpm8fl0EF9r6BVgpGeJH674JAODs1PUn9iMyxvzOQ+oLQiBuLreUYO24DXEwzLk+7+SW9UeLra5tEik0AO0BLyAp57ce6hzewOPxzcsiXCK2Ng8yuTmCiMFKqL8MNclIwL6ojgV3TwhQAMOamXMwL62WJmeNokRZoqxOlpi8u5Gqa0y4NdicZR/rnHTHCKDEE/W5pZI4FEh1KJM3x/nFk5yIgUkuOeNJ2JLOfhyT8vGPGP+j7h0nHY0tdbR6JZTuTdYqUl8JtTF0nPMUWRqLcO9CFVTxdHbivyf6oRwGpz71bB9SBAL/80T3SKSAHLWbLvBCbS57Vm32YNhXhGnpAzGOow9JzEQNQC0Nr+sm6lj0668nLlhWU0kqdv9z+Yh1D1/EdnMxR4ehPk09NtgZOY3x4POd+xK0Sr206zl3/tyJealp+rK9da9ISCGzifylnkD2DFDA+U58fmEZDqq2oO9n6udo14Dt2OzVsagPfwAGNoDzFT3Ts37okMT1+PMVGHNUy9lpizRuSc+zQQCbv804a7I8Kmzf64VZJV5PHOSd1wXu/FfRrmQY5AYuYmi/dJW81ss8xHKkhRmXBYeY4M23rS7n+W7dIwJPdMUwKZP//hGUsZciYgxEwFshtvuDPQF2HC4K9OlUWkwfcn4dE8D8n7J6hAvTchaHcyAZFFhh3zaLHXNaVjTWpqomBCuFE2/QYkuCdnqW8fs3b9cGAOqXiNwcZbB3bSmF0+wtOeM3vigaoh/CpGfJjht7Umu5x1/OoIIycNYVRYmoG06r8ZRTm5JJhAA9mk2DU10NBDbvcjCnZ7n/AC2679xuixgU+M3r7ulyp8tVdA3uhw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: vLTrCdAlrmuwFXv71vWvPXqbLYAKdhHhOQefNrgaHdD0oGOCLEglQFzhNBJFpWz4kfhadCXd9QDykG0QaA8caQ2m6jAM/QT51gj+BME0a638eCqieAii3f55kwwe+i8dTL6oSSZ6I10zTryPZrWpaLbwC9Ije3z6t7hZSLQX00dAk+BONwu05UhkA1/NugCoLpHFcI3dpoG1ddalj8TAi2HpjaXlE/O8hEpmHKbpF23X65Y6lBH2VOh3Bw5n7i80Am5B30cnlWoMZl/t6kp4oq2xO4dHeoprCx4+cC8yBPj5jA73Ze+/L+NN0EC35T5T9L14mRYsbzm3SdgKAnVha0SVvwFSsx32FVKbD1rQ3YAvt0WAb+DxufNCKkBvMmjPMGkOOyDS6+/0jrjDNJE7uc4z8q/pdzELfPSlDeMRcZIL6H4SK7HWieeFMEODxykjhlGGEHwA2XmpTQGQ7G06y6H3aYelLaKL2ok9KrTUpvm42U7/tCDrrv4i4rowWVlVQ3UzxKy6S5DlDpJ/WTAG4GPhxZjogFunP/qBlWRuDm3tz+pMs+s4J1yB5ktYULPGHDBQw3g3uGejVT8H7pvNi87CKg1n3dG8AkBGzhcLOB1EkTrhIPDaYIVY7B9Pe2EHTU9KbNaYbUhEeNyaJhwLDHO1xMaDntOmEpIjgwo/As9Xj6VQB3ehknYYKs9B4rHy3+LH4qvp6WNsOjWMePNEuffkIDknnRRSrDsQyh38mazu+oxwNgMZy9FAioYUARyArro/IHWu1oabKvKt5OgY74NnmIN+E5mXzhdgtIJw6eOZx5eTpgz+HPjkwRaKOnmSInIDdjkEiV3Q8+/waXoX6WbfTxn7STpY0Sm/jYLQ/PlZtX9xZAbiBm14ygF9+oUao6oGu0cFOjVVyoiA5bGnjsnNAHBVPTnnlOXvITNKE0cJz/YU3Dh01LuiYzvgd4Q67wwj64HF9323+EWk/Em2xBRxUB4RYM/Y3un4fNAex0O3J6rwfsDxI3oLot53XE/RkBwvGgzegR/SMJX5SobEc8soR28sB4mzfgMMP0NUL7l9IHWbkot1XBFxWyDzrhoc7aSlx9iAJj/KLjm+3rRHa6XHNm4+l9/LW6fkbNCBC5mJYSv2zhkyVxhbgt68c67+coODT+3ns/d5g8t9yqsId20KwUnB/ajzad0QcPu9yIGMxZoS12WjQBjqCL7PSCl930h/zwcf6gVDqvtulqcd5OtHlQ7XUXhdNqekDkf8MpPveFl8H32M0mJyuvRIC8c7hZDq1AJkiI9Iu/anVyGN0QFDRKioReYzNihT7crVpPlPMfRzI6Szowab+XBQ5yZL Content-ID: <79AAF3C94DAA26419E3636C60430C2ED@INDPRD01.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: e2628023-bf42-4f0b-fd8a-08dd558c64a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2025 11:06:02.8367 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MAZPR01MB8050 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Aditya Garg Remove the redundant else statement from atomic_check since the previous if statement was returning if true. Signed-off-by: Aditya Garg --- drivers/gpu/drm/ast/ast_mode.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index 9d5321c81..3817d1e4c 100644 --- a/drivers/gpu/drm/ast/ast_mode.c +++ b/drivers/gpu/drm/ast/ast_mode.c @@ -610,9 +610,10 @@ static int ast_primary_plane_helper_atomic_check(struct drm_plane *plane, DRM_PLANE_NO_SCALING, DRM_PLANE_NO_SCALING, false, true); - if (ret) { + if (ret) return ret; - } else if (!new_plane_state->visible) { + + if (!new_plane_state->visible) { if (drm_WARN_ON(dev, new_plane_state->crtc)) /* cannot legally happen */ return -EINVAL; else