From patchwork Wed Aug 16 08:28:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Xiangliang Yu X-Patchwork-Id: 9903267 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A0A53603B5 for ; Wed, 16 Aug 2017 08:44:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9122D28990 for ; Wed, 16 Aug 2017 08:44:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 85C47289A6; Wed, 16 Aug 2017 08:44:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, HTML_MESSAGE, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6733928990 for ; Wed, 16 Aug 2017 08:44:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 90C266E407; Wed, 16 Aug 2017 08:43:56 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org X-Greylist: delayed 2901 seconds by postgrey-1.35 at gabe; Wed, 16 Aug 2017 08:43:54 UTC Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0067.outbound.protection.outlook.com [104.47.36.67]) by gabe.freedesktop.org (Postfix) with ESMTPS id CF3066E405; Wed, 16 Aug 2017 08:43:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=F++Hvnds7S5XRv/GvaozWEUZQxD28Ko2aKuHHofEji8=; b=grhGA27M+ClYRGBZILpOmNfGPWUihYzRmztJaWj5LRu2tyjtSrcvyA/Ro2u2onJdi8CHgV+G0kRTmKTbNksTVJ5Lgg/pT1lAGZB3SQED26OcpBHlxoCY1xWyvKWyqM254lXVIcuyJ4ZZPQ+YX2XYZfniJj4xIH3et8426OLBstA= Received: from BY2PR1201MB0935.namprd12.prod.outlook.com (10.164.167.19) by CY1PR12MB0460.namprd12.prod.outlook.com (10.163.91.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1362.18; Wed, 16 Aug 2017 08:28:28 +0000 Received: from BY2PR1201MB0935.namprd12.prod.outlook.com ([10.164.167.19]) by BY2PR1201MB0935.namprd12.prod.outlook.com ([10.164.167.19]) with mapi id 15.01.1341.020; Wed, 16 Aug 2017 08:28:17 +0000 From: "Yu, Xiangliang" To: =?iso-8859-1?Q?Christian_K=F6nig?= , "Liu, Monk" , "akpm@linux-foundation.org" , "labbott@redhat.com" , "dri-devel@lists.freedesktop.org" , "amd-gfx@lists.freedesktop.org" Subject: RE: [PATCH 1/1] drm/ttm: Fix accounting error when fail to get pages for pool Thread-Topic: [PATCH 1/1] drm/ttm: Fix accounting error when fail to get pages for pool Thread-Index: AQHTFmA/pAF0gYtwg0+pfU9icHg43qKGlQkAgAAINoCAAAj7sA== Date: Wed, 16 Aug 2017 08:28:17 +0000 Message-ID: References: <1502868046-32511-1-git-send-email-Xiangliang.Yu@amd.com> <8f64cef6-e7f7-e245-93b9-a0d1bbc411aa@vodafone.de> In-Reply-To: <8f64cef6-e7f7-e245-93b9-a0d1bbc411aa@vodafone.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Xiangliang.Yu@amd.com; x-originating-ip: [116.228.147.241] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY1PR12MB0460; 20:YeaafcLqoKCdzVkASzjs9SMY7Kdepd7U3NdyQZjOs13L0Z52/wATahHrlAk/esnib4+N/NClFZM4/1HYdGQtJTZ0TyRTit/pw7gO1iQGQg/Vs9sl3C/bEOciRG49oMWCCMJWi6ouJjH7eHaElhrhFpCFhO8b0zhITr5RxZbUmpqnNxnzjHT4oMu8t+Baq3+5I/GGPytpBgLq+0mHyVi8y4d1HKs1FoPQw4Oh7+cqTabwLdFABoXiXfhQXNzFvBKj x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(39860400002)(189002)(199003)(377454003)(86362001)(2201001)(6246003)(55016002)(81166006)(81156014)(14454004)(99286003)(6506006)(9686003)(7696004)(478600001)(4326008)(8936002)(33656002)(25786009)(53936002)(6306002)(8676002)(97736004)(10710500007)(101416001)(2420400007)(6436002)(68736007)(77096006)(3846002)(6116002)(790700001)(102836003)(2501003)(54356999)(106356001)(72206003)(66066001)(105586002)(2906002)(606006)(76176999)(3280700002)(50986999)(189998001)(53546010)(236005)(7110500001)(15650500001)(2900100001)(2950100002)(3660700001)(7736002)(74316002)(5660300001)(966005)(54896002)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR12MB0460; H:BY2PR1201MB0935.namprd12.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; x-ms-office365-filtering-correlation-id: b2c96962-356d-4a26-7c1d-08d4e480befa x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY1PR12MB0460; x-ms-traffictypediagnostic: CY1PR12MB0460: x-exchange-antispam-report-test: UriScan:(767451399110)(217544274631240)(21748063052155); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR12MB0460; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR12MB0460; x-forefront-prvs: 0401647B7F received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2017 08:28:17.5709 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0460 Cc: "stable@vger.kernel.org" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Ok, CC stable. From: Christian König [mailto:deathsimple@vodafone.de] Sent: Wednesday, August 16, 2017 3:55 PM To: Liu, Monk ; Yu, Xiangliang ; akpm@linux-foundation.org; labbott@redhat.com; dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/1] drm/ttm: Fix accounting error when fail to get pages for pool CC stable? Reviewed-by: Christian König Am 16.08.2017 um 09:25 schrieb Liu, Monk: Reviewed-by: Monk Liu diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index eeddc1e..8715998 100644 --- a/drivers/gpu/drm/ttm/ttm_page_alloc.c +++ b/drivers/gpu/drm/ttm/ttm_page_alloc.c @@ -615,7 +615,7 @@ static void ttm_page_pool_fill_locked(struct ttm_page_pool *pool, } else { pr_err("Failed to fill pool (%p)\n", pool); /* If we have any pages left put them to the pool. */ - list_for_each_entry(p, &pool->list, lru) { + list_for_each_entry(p, &new_pages, lru) { ++cpages; } list_splice(&new_pages, &pool->list);