From patchwork Mon Jan 28 00:16:25 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sedat Dilek X-Patchwork-Id: 2053551 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id 4A3B13FD1A for ; Mon, 28 Jan 2013 07:28:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2847FE6280 for ; Sun, 27 Jan 2013 23:28:29 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qe0-f52.google.com (mail-qe0-f52.google.com [209.85.128.52]) by gabe.freedesktop.org (Postfix) with ESMTP id CDA96E5DEF; Sun, 27 Jan 2013 16:16:25 -0800 (PST) Received: by mail-qe0-f52.google.com with SMTP id 6so631505qeb.25 for ; Sun, 27 Jan 2013 16:16:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:reply-to:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=ETdjatNNCDPB88kjrzHfEglmkYjplWtdhhocnypy5gI=; b=K3T/bHrghL/uQqhHxal1XPODou5RwSXgV/8xIa44BqNy9zET7fT9h2rsQBtzn+Fs6n GWqUX/6lnmcslBe/oG2namWb2Ce8tG+PX/9RKwnLMS6x9GqECEBZRQNYhtDq1rl/iCBF n0CXjLokNMd/b/bNF4frFqodwbcO8odqdB3dAWdILuVz6pIDKzBCTaaJV7lLERLv0Oo1 nK9PHkbm9mg3CyVbRtEnhJgwnmPbo9vLf9hfd33XoqMbc8lYOKXpGU3oZyxSna8/5p2n i3S303wwua82SJp44pOAM8IFFKXW8V1TBbPmC9svIn2TtUnudiy3fHpYnfcegWPOtGa4 zJ4Q== MIME-Version: 1.0 X-Received: by 10.224.59.134 with SMTP id l6mr13728030qah.93.1359332185190; Sun, 27 Jan 2013 16:16:25 -0800 (PST) Received: by 10.49.87.39 with HTTP; Sun, 27 Jan 2013 16:16:25 -0800 (PST) In-Reply-To: References: Date: Mon, 28 Jan 2013 01:16:25 +0100 Message-ID: Subject: Re: Adding a i915 quirk (here: pipe A force quirk for testing purposes)? From: Sedat Dilek To: intel-gfx X-Mailman-Approved-At: Sun, 27 Jan 2013 23:11:21 -0800 Cc: DRI X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: sedat.dilek@gmail.com List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org On Mon, Jan 28, 2013 at 12:52 AM, Sedat Dilek wrote: > Hi, > > From [1]: > ... > static struct intel_quirk intel_quirks[] = { > /* HP Mini needs pipe A force quirk (LP: #322104) */ > { 0x27ae, 0x103c, 0x361a, quirk_pipea_force }, > ... > } > > Triple - which value is what? > > 00:02.0 VGA compatible controller [0300]: Intel Corporation 2nd > Generation Core Processor Family Integrated Graphics Controller > [8086:0116] (rev 09) (prog-if 00 [VGA controller]) > Subsystem: Samsung Electronics Co Ltd Device [144d:c0c7] > Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- > ParErr- Stepping- SERR- FastB2B- DisINTx+ > Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- > SERR- Latency: 0 > Interrupt: pin A routed to IRQ 49 > Region 0: Memory at f0000000 (64-bit, non-prefetchable) [size=4M] > Region 2: Memory at e0000000 (64-bit, prefetchable) [size=256M] > Region 4: I/O ports at 3000 [size=64] > Expansion ROM at [disabled] > Capabilities: > Kernel driver in use: i915 > > $ dmesg | egrep -i 'drm|i915' | grep dump_device_info > [ 15.242823] [drm:i915_dump_device_info], i915 device info: gen=6, > pciid=0x0116 flags=is_mobile,need_gfx_hws,has_force_wake,has_fbc,has_hotplug,has_bsd_ring,has_blt_ring,has_llc, > > OK, 0x0116 is the PCI-ID. > > Seen also here... > Intel Corporation 2nd Generation Core Processor Family Integrated > Graphics Controller [8086:0116] (rev 09) > > The two other values are from this line? > > Subsystem: Samsung Electronics Co Ltd Device [144d:c0c7] > > If so, what is what in triple :-)? > > Thanks in advance. > Something like the below is OK? [ Xorg.0.log ] [ 16.421] (--) PCI:*(0:0:2:0) 8086:0116:144d:c0c7 rev 9, Mem @ 0xf0000000/4194304, 0xe0000000/268435456, I/O @ 0x00003000/64 - Sedat - > Regards, > - Sedat - > > > http://cgit.freedesktop.org/~danvet/drm-intel/tree/drivers/gpu/drm/i915/intel_display.c?h=drm-intel-nightly#n8609 diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 0e2030f..1f33994 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -8613,6 +8613,9 @@ static const struct intel_dmi_quirk intel_dmi_quirks[] = { }; static struct intel_quirk intel_quirks[] = { + /* Samsung NP530U3B-A01DE needs pipe A force quirk */ + { 0x0116, 0x144d, 0xc0c7, quirk_pipea_force }, + /* HP Mini needs pipe A force quirk (LP: #322104) */ { 0x27ae, 0x103c, 0x361a, quirk_pipea_force },