From patchwork Wed Apr 27 15:28:20 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rodrigo Vivi X-Patchwork-Id: 8959021 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A43A59F441 for ; Wed, 27 Apr 2016 15:28:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B016620155 for ; Wed, 27 Apr 2016 15:28:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id B9A8A20263 for ; Wed, 27 Apr 2016 15:28:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D59286EB40; Wed, 27 Apr 2016 15:28:23 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2DEAE6EB40 for ; Wed, 27 Apr 2016 15:28:22 +0000 (UTC) Received: by mail-io0-x22c.google.com with SMTP id f89so49707119ioi.0 for ; Wed, 27 Apr 2016 08:28:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-transfer-encoding; bh=HaMsfW3sGQxa5lsyS9smr1kreYkeMIq4/82VGXwZe2Q=; b=Q4jCaaUqeq3IW0VmpRp0Wo0SSS9O8imhYzBampK0G2keDxpA2Fk6yy6tlUSb8ZWkwF BUkvJ+JBAtnlgtAe8sGOjPtCJfAjm+rhYtX7lCTE00oy8xZ1DSjjOIlk2FX9m/vOMLzS hNlFpaEaBf68mnmx3MO9MfmTPKqFFZdvpVGYP9tNrwKNKXOUVyiWW+akEupMyW0KhZNv lrAKs8TscaQOpWGSXobWXuN3YvOUjw1IZJgQfPsaN7F8hvr3zU/Ttw4+WPu4N4Je3NPa ww981+Dnc5MABgiLufv8IWpm9TzOW0grewtRnsFvQVAOjRUH4qVB+lHf+m/czZNBVd8j 3dyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=HaMsfW3sGQxa5lsyS9smr1kreYkeMIq4/82VGXwZe2Q=; b=IVDCior4EEziM2mQZFXYO0uT8HrSqPJIlRxuryYgRpkL3mRhQvUCqX8SOXHyPqchra 55yv/KkkI9/DpFPlmMyEzRwWtJWJsEwcaIfZRXEgi4yKv0pg9n5Gz/0bRSHG1Xnf5uuJ 869n/kpAvZHFcdXNjlS4uSC/uMvQYavD2PBUlg6h9iY7Ds4jiemYEw1jhCYjbTiefwcK /bx3scsI2bXZp9AH+YreRSensQM0djXR2ccpt3r/Galk8QNA6t/FZ2hGoYeQAR35eTII Gc35PNqRxEM2wyNt2FtH8plVRu+e42dvRbiKmm/frB0f5e+bhKa0kaFrrIs+MoeFJnAs aWAA== X-Gm-Message-State: AOPr4FXG9BT6w0Y5Azh/77qcrHctd4Qx4J0cRkvvFxEdPRixjzS1zYM4aPsZJ0cBmaxBXIrkIit8tyzqgzB1OA== MIME-Version: 1.0 X-Received: by 10.107.156.203 with SMTP id f194mr4789943ioe.112.1461770900773; Wed, 27 Apr 2016 08:28:20 -0700 (PDT) Received: by 10.36.105.206 with HTTP; Wed, 27 Apr 2016 08:28:20 -0700 (PDT) In-Reply-To: <87k2jjjq59.fsf@intel.com> References: <20160427004639.53a15c35@mdontu-l> <877ffjle8j.fsf@intel.com> <20160427130755.3f9d9c53@mdontu-l> <87k2jjjq59.fsf@intel.com> Date: Wed, 27 Apr 2016 08:28:20 -0700 Message-ID: Subject: Re: i915: screen flicker From: Rodrigo Vivi To: Jani Nikula , "Pandiyan, Dhinakaran" , Paulo Zanoni Cc: Daniel Vetter , DRI mailing list X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Mihai, What platform do you have? HSW or BDW? If you don't know please provide lspci -nn What happens if you boot with i915.enable_psr=2? In case it helps, could you please boot with default i915.enable_psr=-1 appying this patch to your kernel to know what your VBT recommends: if (i915.enable_psr == 2 && !dev_priv->psr.link_standby) { DRM_DEBUG_KMS("PSR: Forcing link standby\n"); //Thanks //Rodrigo. On Wed, Apr 27, 2016 at 3:35 AM, Jani Nikula wrote: > On Wed, 27 Apr 2016, Mihai Don?u wrote: >> On Wed, 27 Apr 2016 10:09:32 +0300 Jani Nikula wrote: >>> On Wed, 27 Apr 2016, Mihai Don?u wrote: >>> > I noticed that since I started using 4.6.0-rcX, my screen flickers once >>> > or twice after I stop using my laptop for ~1min or so. Given the >>> > behavior, my prime suspect is the PSR feature that you have announced >>> > for this release: >>> > >>> > http://blog.ffwll.ch/2016/03/neat-drmi915-stuff-for-46.html >>> > >>> > Is 'enable_psr' the right knob to use to turn this feature off and see >>> > if my suspicions are correct? Or is there a patch floating around that >>> > I can test? >>> >>> i915.enable_psr=0 is the one to try, yes. >> >> I can confirm that with PSR off, the flicker goes away. > > Please file a bug at [1] and assign to Rodrigo (Cc'd). > > BR, > Jani. > > [1] https://bugs.freedesktop.org/enter_bug.cgi?product=DRI&component=DRM/Intel > > > -- > Jani Nikula, Intel Open Source Technology Center diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c index c3abae4..68bc405 100644 --- a/drivers/gpu/drm/i915/intel_psr.c +++ b/drivers/gpu/drm/i915/intel_psr.c @@ -798,6 +798,8 @@ void intel_psr_init(struct drm_device *dev) /* For new platforms let's respect VBT back again */ dev_priv->psr.link_standby = dev_priv->vbt.psr.full_link; + DRM_ERROR("PSR: VBT recommends link_standby %d, using %d\n", dev_priv->vbt.psr.full_link, dev_priv->psr.link_standby); + /* Override link_standby x link_off defaults */