From patchwork Tue Oct 8 20:19:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Rob Clark X-Patchwork-Id: 3005361 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C4867BF924 for ; Tue, 8 Oct 2013 20:49:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D702A201F2 for ; Tue, 8 Oct 2013 20:49:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id F0332201EF for ; Tue, 8 Oct 2013 20:49:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E7B67E71D4 for ; Tue, 8 Oct 2013 13:49:38 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ie0-f177.google.com (mail-ie0-f177.google.com [209.85.223.177]) by gabe.freedesktop.org (Postfix) with ESMTP id E5C01E5E4F for ; Tue, 8 Oct 2013 13:48:45 -0700 (PDT) Received: by mail-ie0-f177.google.com with SMTP id qd12so19739638ieb.8 for ; Tue, 08 Oct 2013 13:48:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=SX/SMMn/dPYLtmH/6fFIUaQBTzr9nqquRF3w0XknN1o=; b=CBDRSUk6zbkc6LOmH+zxwvq+3OeUfR5tiHjqqz5iQ96iVRDZQJpV7VXtB1AsDMn8xg jGQaapCaRGPimFnBnLPfuTbX0qxGDL3cUtQDO13Dtx0cNxLjk9ZiAcZAbeLYg4l0j7iS zvKihk2a/QV5Y4l5ZkLpQVqrbjx26kFk+1e4dijAFCbxJt82X80Nt3IqDzjQNoZca3Tb YDZSOtgwxPsCb4B6waVzh7D5hzfUw5/NDhkcpkkQrL67U2hddpSXh2CVy+ctHqe0o4hd Fu2qArPr70s7BfnuwLvfjsN3Bbtl3HEIz6RFrU77kL6J0x0J3FOZ9l0RyTzYN74gOd9s kvIg== MIME-Version: 1.0 X-Received: by 10.50.20.3 with SMTP id j3mr2779776ige.11.1381263581820; Tue, 08 Oct 2013 13:19:41 -0700 (PDT) Received: by 10.50.149.130 with HTTP; Tue, 8 Oct 2013 13:19:41 -0700 (PDT) In-Reply-To: <20131008195754.GA2010@thor.baobob.org> References: <1375897287-8787-1-git-send-email-robdclark@gmail.com> <1375897287-8787-8-git-send-email-robdclark@gmail.com> <20131008195754.GA2010@thor.baobob.org> Date: Tue, 8 Oct 2013 16:19:41 -0400 Message-ID: Subject: Re: [PATCH 7/9] drm/gma500: use gem get/put page helpers From: Rob Clark To: =?ISO-8859-1?Q?Guillaume_CL=C9MENT?= Cc: "dri-devel@lists.freedesktop.org" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Oct 8, 2013 at 3:57 PM, Guillaume CLÉMENT wrote: > On Wed, Aug 07, 2013 at 01:41:25PM -0400, Rob Clark wrote: >> Signed-off-by: Rob Clark >> --- >> drivers/gpu/drm/gma500/gtt.c | 38 ++++++-------------------------------- >> 1 file changed, 6 insertions(+), 32 deletions(-) >> [ snip ] > > This is quite late to report, but I've just begun testing 3.12, and this > patch makes my screen garbled when using the modesetting xorg driver. > > So far it looks like the buffer that the xorg driver gets is > not the one that is actually mapped by the kernel. > > I'm currently trying to know what exactly causes the problem, but I don't > know anything about the internals here... > could you try this small patch.. I think I missed something w/ my original patch (sorry, no hw to test on here): ---------- ---------- > > I doubt it will help, but the fbdev driver still works with this patch. > > > - Guillaume diff --git a/drivers/gpu/drm/gma500/gtt.c b/drivers/gpu/drm/gma500/gtt.c index 92babac..2db731f 100644 --- a/drivers/gpu/drm/gma500/gtt.c +++ b/drivers/gpu/drm/gma500/gtt.c @@ -204,6 +204,7 @@ static int psb_gtt_attach_pages(struct gtt_range *gt) if (IS_ERR(pages)) return PTR_ERR(pages); + gt->npage = gt->gem.size / PAGE_SIZE; gt->pages = pages; return 0;