From patchwork Sun Sep 8 00:13:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Herrmann X-Patchwork-Id: 2856741 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 5F366BF43F for ; Sun, 8 Sep 2013 00:13:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 591572038E for ; Sun, 8 Sep 2013 00:13:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 11EFF2037A for ; Sun, 8 Sep 2013 00:13:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E727E6087 for ; Sat, 7 Sep 2013 17:13:37 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ie0-f178.google.com (mail-ie0-f178.google.com [209.85.223.178]) by gabe.freedesktop.org (Postfix) with ESMTP id 02994E5DE6 for ; Sat, 7 Sep 2013 17:13:26 -0700 (PDT) Received: by mail-ie0-f178.google.com with SMTP id f4so10233518iea.9 for ; Sat, 07 Sep 2013 17:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=kagMT4v4qDEQiWKEmTC82xxoXCy6CFuO+l+kxMcmy+8=; b=LeRZxvcRmVU82eDxoyHaJWY+tGK9tgM6uMOjJdFr7HbuE4vpgw9GN7G3WZGF3qYWFQ FCY7EY4pa/qwgrpYDj4LRMD10iRqLfBn9w6lW3ugHVnK0bwoHsvC1kyDkSIHK1vXyRCa wsUcixGdgCh8ZiBLD23thUsnYbiuzZRFEU3cYmoHDxhg1nr5RiX4ECdgs7yg7lEM+kxO tRvQf2hddjbNkoltV3OmPA0Rj+XuftQlH+afbaH3H5D0jvBLEEd9Jc/maVsOI+0010wt +iebl3w/3QtnUEQEhiu/6hbDBluz9k0D3mX/gaXK0thQkaDUOMLmHSqGnpQParqpQ3ne FuDQ== MIME-Version: 1.0 X-Received: by 10.42.146.1 with SMTP id h1mr159639icv.38.1378599206482; Sat, 07 Sep 2013 17:13:26 -0700 (PDT) Received: by 10.42.142.195 with HTTP; Sat, 7 Sep 2013 17:13:26 -0700 (PDT) In-Reply-To: References: Date: Sun, 8 Sep 2013 02:13:26 +0200 Message-ID: Subject: Re: [REGRESSION] v3.12-rc1: i915_driver_load oopses when sysfb enabled From: David Herrmann To: Tom Gundersen Cc: Daniel Vetter , LKML , "dri-devel@lists.freedesktop.org" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi On Sun, Sep 8, 2013 at 1:22 AM, Tom Gundersen wrote: > Hi David, > > On Sat, Sep 7, 2013 at 11:57 PM, Tom Gundersen wrote: >> On Sat, Sep 7, 2013 at 4:30 PM, David Herrmann wrote: >>> Attached are two patches. The first one should fix this issue, the >>> second one is the rebased ioremap_wc() patch from the other thread. >>> >>> Does this fix the issue (and the speed-problems)? >> >> Sadly, no. I added a few printk's to verify that the function you >> added is called (it is), but still the same oops. > > A few more datapoints: > > Triggers: > X86_SYSFB=y and FB_SIMPLE=n (so no fbdev until i915 is loaded) > X86_SYSFB=y and FB_SIMPLE=y > > Does not trigger: > X86_SYSFB=y, FB_EFI=yes, and without the overflow fix (i.e., so we > fall back to efifb) > X86_SYSFB=n and FB_EFI=y > X86_SYSFB=n and FB_EFI=n (so no fbdev until i915 is loaded) > > Does this make any sense? Thanks a lot for these results. I think I got it know. I will write a patch that marks the resource as busy. See: kernel/resource.c iomem_map_sanity_check() It also contains a hint that we should set this for driver-resources which not directly map to hardware resources (such as veasfb and, obviously, simplefb). Following a diff which hopefully fixes this. The other two patches should still be required, though. I will try to write a proper patch tomorrow. Thanks a lot for these extensive tests, Tom! David diff --git a/arch/x86/kernel/sysfb_simplefb.c b/arch/x86/kernel/sysfb_simplefb.c index 22513e9..b7bb615 100644 --- a/arch/x86/kernel/sysfb_simplefb.c +++ b/arch/x86/kernel/sysfb_simplefb.c @@ -79,7 +79,7 @@ __init int create_simplefb(const struct screen_info *si, /* setup IORESOURCE_MEM as framebuffer memory */ memset(&res, 0, sizeof(res)); - res.flags = IORESOURCE_MEM; + res.flags = IORESOURCE_MEM | IORESOURCE_BUSY; res.name = simplefb_resname; res.start = si->lfb_base; res.end = si->lfb_base + len - 1;