From patchwork Thu Aug 4 07:32:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Herrmann X-Patchwork-Id: 9262813 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B4F3C60754 for ; Thu, 4 Aug 2016 07:32:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A98D127F0B for ; Thu, 4 Aug 2016 07:32:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9DBA928319; Thu, 4 Aug 2016 07:32:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 80D4A27F0B for ; Thu, 4 Aug 2016 07:32:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0A7E46E061; Thu, 4 Aug 2016 07:32:08 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lf0-x244.google.com (mail-lf0-x244.google.com [IPv6:2a00:1450:4010:c07::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 11FFF6E061 for ; Thu, 4 Aug 2016 07:32:05 +0000 (UTC) Received: by mail-lf0-x244.google.com with SMTP id 33so13765144lfw.3 for ; Thu, 04 Aug 2016 00:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=y57vxhxBY2VWtVTLP80uP6bzXvXcwfcP+BpjbCI+rGg=; b=R1ptZ4hJWng+y04ls6g8mngtAoFYGTLhwQXx/0DPT+4MYIpPX+EApXNQKkUPjRhVLv Wps2Go0ADHox4hfetOjYbzdlLBT+zqFkovVDD/woBd8aVkKK6XpG88Ws3zbyDAv5CZcR x76KFhG6gzd6W4Jvdp4VrL3PlRY//lDQtJtX7dJcOjrQmonJpyJsQtUttUpKvr5kLfU2 sPSG+zZBo81/+ZU4S4geh3Ak97DvMo74wncN67F3Iwzoc3z+Pw59wO8I/QIGxYXOVLMZ nn+f9Vs+Rwf4lQqs9zfDRcKYXNTVtvqbj8atUwxmRekE53NRXfArq9pVqp2trXaZSb2l J3WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=y57vxhxBY2VWtVTLP80uP6bzXvXcwfcP+BpjbCI+rGg=; b=hg1BMdxTF93BswM2GEwSI60XMDhGUy6cxzIeOOuZBg4AZcwJ+YvmvkBK2MgJ+xVzXd 9FbOiFbkkPzK8SRhd/1eIb/HfTLIYtJiNr9aBd+ywOJZkK8zWMJkGIeaSGhIGDOn5A/+ YHiyuJqoyHiRmA1rxCz6GhDotuc6GZUQYfwxAvKu7YLkT3T63x7fAAPhW1/nk+0ABB+t YeB6c3gs4gMi3rZLP84F0qlDBhfo3eMFQ1k+h/7EUx/aI3ig/aUfduI8HmAO8KewiVrH Nlw/9JuUvREJ3CFFmYvzSl1Ap4XT2qLYbdbzy2+fUIgVZ0x8VtUzDgbSLR9gD6bPv9su ejgg== X-Gm-Message-State: AEkoouu/vU2z9c8EfcuaFNsW2iggTfktXnZx4gkmROJxX1j1z/Ddx0MI5CJU/heO1AAxqd95FJpfeAwjAuGQgw== X-Received: by 10.46.32.224 with SMTP id g93mr21684316lji.33.1470295922198; Thu, 04 Aug 2016 00:32:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.135.130 with HTTP; Thu, 4 Aug 2016 00:32:01 -0700 (PDT) In-Reply-To: <1470251470-30830-1-git-send-email-daniel.vetter@ffwll.ch> References: <1470251470-30830-1-git-send-email-daniel.vetter@ffwll.ch> From: David Herrmann Date: Thu, 4 Aug 2016 09:32:01 +0200 Message-ID: Subject: Re: [PATCH 1/2] drm: Mark up legacy/dri1 drivers with DRM_LEGACY To: Daniel Vetter Cc: Daniel Vetter , DRI Development X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Hi On Wed, Aug 3, 2016 at 9:11 PM, Daniel Vetter wrote: > It's super confusing that new drivers need to be marked with > DRIVER_MODESET when really it means DRIVER_MODERN. Much better to > invert the meaning and rename it to something that's suitably > off-putting. > > Since there's over 100 places using DRIVER_MODESET we need to roll out > this change without a flag day. > > v2: Update docs. > > Signed-off-by: Daniel Vetter > --- > Documentation/gpu/drm-internals.rst | 9 ++++++--- > drivers/gpu/drm/i810/i810_drv.c | 4 +--- > drivers/gpu/drm/mga/mga_drv.c | 2 +- > drivers/gpu/drm/r128/r128_drv.c | 2 +- > drivers/gpu/drm/savage/savage_drv.c | 2 +- > drivers/gpu/drm/sis/sis_drv.c | 2 +- > drivers/gpu/drm/tdfx/tdfx_drv.c | 1 + > drivers/gpu/drm/via/via_drv.c | 2 +- > include/drm/drmP.h | 1 + > 9 files changed, 14 insertions(+), 11 deletions(-) Reviewed-by: David Herrmann Also, how about this: diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index fc35731..e609cfc 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -111,6 +111,7 @@ source "drivers/gpu/drm/i2c/Kconfig" config DRM_TDFX tristate "3dfx Banshee/Voodoo3+" depends on DRM && PCI + depends on BROKEN help Choose this option if you have a 3dfx Banshee or Voodoo3 (or later), graphics card. If M is selected, the module will be called tdfx. @@ -120,6 +121,7 @@ source "drivers/gpu/drm/arm/Kconfig" config DRM_R128 tristate "ATI Rage 128" depends on DRM && PCI + depends on BROKEN select FW_LOADER help Choose this option if you have an ATI Rage 128 graphics card. If M @@ -181,6 +183,7 @@ config DRM_I810 tristate "Intel I810" # !PREEMPT because of missing ioctl locking depends on DRM && AGP && AGP_INTEL && (!PREEMPT || BROKEN) + depends on BROKEN help Choose this option if you have an Intel I810 graphics card. If M is selected, the module will be called i810. AGP support is required @@ -191,6 +194,7 @@ source "drivers/gpu/drm/i915/Kconfig" config DRM_MGA tristate "Matrox g200/g400" depends on DRM && PCI + depends on BROKEN select FW_LOADER help Choose this option if you have a Matrox G200, G400 or G450 graphics @@ -201,6 +205,7 @@ config DRM_SIS tristate "SiS video cards" depends on DRM && AGP depends on FB_SIS || FB_SIS=n + depends on BROKEN help Choose this option if you have a SiS 630 or compatible video chipset. If M is selected the module will be called sis. AGP @@ -209,6 +214,7 @@ config DRM_SIS config DRM_VIA tristate "Via unichrome video cards" depends on DRM && PCI + depends on BROKEN help Choose this option if you have a Via unichrome or compatible video chipset. If M is selected the module will be called via. @@ -216,6 +222,7 @@ config DRM_VIA config DRM_SAVAGE tristate "Savage video cards" depends on DRM && PCI + depends on BROKEN help Choose this option if you have a Savage3D/4/SuperSavage/Pro/Twister chipset. If M is selected the module will be called savage.