From patchwork Tue May 2 20:06:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9708567 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3384760349 for ; Tue, 2 May 2017 20:19:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 26D6828558 for ; Tue, 2 May 2017 20:19:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1B7912858A; Tue, 2 May 2017 20:19:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9AC3928558 for ; Tue, 2 May 2017 20:19:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7889F88E56; Tue, 2 May 2017 20:19:35 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.web.de (mout.web.de [212.227.17.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4202888E56; Tue, 2 May 2017 20:19:34 +0000 (UTC) Received: from [192.168.1.2] ([77.182.79.197]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0Lkh7Q-1dfnhT00to-00aVzu; Tue, 02 May 2017 22:06:47 +0200 Subject: [PATCH 1/3] GPU-DRM-Radeon: Use seq_putc() in radeon_sa_bo_dump_debug_info() From: SF Markus Elfring To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , David Airlie References: <74d2df52-f509-e6d2-5b35-e25b7cbd1fbe@users.sourceforge.net> Message-ID: Date: Tue, 2 May 2017 22:06:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <74d2df52-f509-e6d2-5b35-e25b7cbd1fbe@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:02VtJWyUcS4TrlqficyFl2Y7fwJcJE/T+dIH9Y2lhHdFZ6LIKwF uLTKj2eOkOsSrN4VBDExGuQqR4hbU7/KfG7vk039iAgEEeGKREVEfXtKwGgJCZB7EhsRYdg KuLmXD3tZEMobS716lGf31iNsoubbf5eerXUPziJ7FpOgU/VxCVPLFYxEoAxGqh+l2lnv3M /g0GBcOA6Pz/Cuj630gAA== X-UI-Out-Filterresults: notjunk:1; V01:K0:lIhLmIHpwig=:qDtmFGET7Ae9dzUJzwjF4i uIwGBf69YLcg7o0NElWWDhhrcybnX74hClrKApkKwOUq+PSTT5XTy1P7HDoX/L5XanQvnVe1y SSCuZyBEBQms6BQYfOXHJ8er8nrIu66VfCUx12cYB5SOKPQMmyoFpSKgxcJ/SoCdVR1Q96Dwg 85KXYPhIZFMYUKZFdbSxO6u47YOys4YcrO5byfUYKGmD4H3Y0+ZQmg8bmwVBRjVQ2rk0wxwtw WSoJZAi6N3/AtL673jX08iWIWv8jB/rhFMq1oe3ebc6oVNv2l1TxM0w/YJ4Tn+v2t6usnBKmq /NzreuSOwJEdJsCGbIE8GYF48auCIFa22C0Ojw/r6GMPcEWNBpSx6s2mQdUcsinrEpjv3Q5T1 VuLnQH4QJw0ASEtPvTzG0/FWddr9JZVbfVotAT4Ke+wY5HuzX+sK/Dr0qVkwieTkH5dDGjgSa c26KA3KFNKiLXo0X3ax1oB5Avt8k8HyiawCTQy9Xi304I2vKEWu7SeZCqdBKwmKKykFbT9Bd0 0qnbsbX6wXLDd8OY8yw09gj7/ZZJi3FKm7yvDzjJl+36hxggRVamVzhlEZvjB1r9QKtFn9fRh yYUWAvm+bQU8ywYAvGlcRk+XrcHapZUHM28vaDkjnZtd4mj7KGE7WxfUHY8W5pfErSLPdDhOQ qWA4hF/Hug6qNhUlryYhgBT922QzhOuTMuNtvinDg7NVtw8iYFOdXed6PX5mp5DmKMcKSU6km J2YRXx+TU7JEsthbPT3esfpEXUyvtduDzI2wNqhsZsB3DGSMW/3sQL9YTWqUw2vJfIPkZ7YMS 9mDit2C Cc: kernel-janitors@vger.kernel.org, LKML X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Tue, 2 May 2017 21:35:48 +0200 A few single characters should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/radeon/radeon_sa.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_sa.c b/drivers/gpu/drm/radeon/radeon_sa.c index 197b157b73d0..67bc3618798d 100644 --- a/drivers/gpu/drm/radeon/radeon_sa.c +++ b/drivers/gpu/drm/radeon/radeon_sa.c @@ -406,18 +406,15 @@ void radeon_sa_bo_dump_debug_info(struct radeon_sa_manager *sa_manager, list_for_each_entry(i, &sa_manager->olist, olist) { uint64_t soffset = i->soffset + sa_manager->gpu_addr; uint64_t eoffset = i->eoffset + sa_manager->gpu_addr; - if (&i->olist == sa_manager->hole) { - seq_printf(m, ">"); - } else { - seq_printf(m, " "); - } + + seq_putc(m, (&i->olist == sa_manager->hole) ? '>' : ' '); seq_printf(m, "[0x%010llx 0x%010llx] size %8lld", soffset, eoffset, eoffset - soffset); if (i->fence) { seq_printf(m, " protected by 0x%016llx on ring %d", i->fence->seq, i->fence->ring); } - seq_printf(m, "\n"); + seq_putc(m, '\n'); } spin_unlock(&sa_manager->wq.lock); }