diff mbox

drm: vc4: fix device_node_continue.cocci warnings

Message ID alpine.DEB.2.20.1801201907400.2635@hadrien (mailing list archive)
State New, archived
Headers show

Commit Message

Julia Lawall Jan. 20, 2018, 6:09 p.m. UTC 
From: Fengguang Wu <fengguang.wu@intel.com>

 Device node iterators put the previous value of the index variable, so an
 explicit put causes a double put.

Generated by: scripts/coccinelle/iterators/device_node_continue.cocci

Fixes: 88e6e13dd66c ("drm: vc4: Use drm_atomic_helper_shutdown() to disable planes on removal")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---

url:
https://github.com/0day-ci/linux/commits/Laurent-Pinchart/Cargo-cult-cleanup-in-atomic-drivers/20180120-183018
base:   git://people.freedesktop.org/~airlied/linux.git drm-next
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago

Please take the patch only if it's a positive warning. Thanks!

 zx_drm_drv.c |    1 -
 1 file changed, 1 deletion(-)
diff mbox

Patch

--- a/drivers/gpu/drm/zte/zx_drm_drv.c
+++ b/drivers/gpu/drm/zte/zx_drm_drv.c
@@ -163,7 +163,6 @@  static int zx_drm_probe(struct platform_

 	for_each_available_child_of_node(parent, child) {
 		component_match_add(dev, &match, compare_of, child);
-		of_node_put(child);
 	}

 	return component_master_add_with_match(dev, &zx_drm_master_ops, match);