diff mbox series

drm/nouveau/debugfs: fix pm_runtime.cocci warnings (fwd)

Message ID alpine.DEB.2.20.1807280815360.2466@hadrien (mailing list archive)
State New, archived
Headers show
Series drm/nouveau/debugfs: fix pm_runtime.cocci warnings (fwd) | expand

Commit Message

Julia Lawall July 28, 2018, 6:19 a.m. UTC 
From: kbuild test robot <fengguang.wu@intel.com>

pm_runtime_get_sync returns < 0 as error. Unecessary IS_ERR_VALUE at line 164

Generated by: scripts/coccinelle/api/pm_runtime.cocci

Fixes: eaeb9010bb4b ("drm/nouveau/debugfs: Wake up GPU before doing any reclocking")
CC: Karol Herbst <karolherbst@gmail.com>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---

Please take the patch only if it's a positive warning. Thanks!

 nouveau_debugfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

--- a/drivers/gpu/drm/nouveau/nouveau_debugfs.c
+++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
@@ -161,7 +161,7 @@  nouveau_debugfs_pstate_set(struct file *
 	}

 	ret = pm_runtime_get_sync(drm->dev);
-	if (IS_ERR_VALUE(ret) && ret != -EACCES)
+	if (ret < 0 && ret != -EACCES)
 		return ret;
 	ret = nvif_mthd(ctrl, NVIF_CONTROL_PSTATE_USER, &args, sizeof(args));
 	pm_runtime_put_autosuspend(drm->dev);