From patchwork Sun Jun 12 11:02:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 12878699 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D321CCA473 for ; Sun, 12 Jun 2022 11:02:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C896910F980; Sun, 12 Jun 2022 11:02:36 +0000 (UTC) Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by gabe.freedesktop.org (Postfix) with ESMTPS id A70CA10F980 for ; Sun, 12 Jun 2022 11:02:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:message-id:mime-version; bh=JUYU3aqCoEdG9jehlyG1aKnpn6Chafc4XXOZBNqZ6PY=; b=rXJHR/72ezrn2anPILZY3SDPdlDExwLi4v3xr8XkrFNo0+Q1t4vB8Kjy X0fXYiC45xQpp1cBtInVsyTbSTeUaAEMcfQbo8BMFIl42CRBORtm+c5yc fyToCdU6bRPcEQ4NR5XBDCylh/KDdFKUiHM9QdgG48CsnlSv3PrmFNosj k=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.91,294,1647298800"; d="scan'208";a="40585989" Received: from 245.122.68.85.rev.sfr.net (HELO hadrien) ([85.68.122.245]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2022 13:02:32 +0200 Date: Sun, 12 Jun 2022 13:02:31 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Paul Kocialkowski Subject: [PATCH] drm: fix device_node_continue.cocci warnings (fwd) Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kbuild-all@lists.01.org, lkp@intel.com, David Airlie , linux-kernel@vger.kernel.org, Linux Memory Management List , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The of_node_put does not seem to be needed. Note that there is none at the preceeding continues. julia ---------- Forwarded message ---------- Date: Sat, 11 Jun 2022 06:02:45 +0800 From: kernel test robot To: kbuild@lists.01.org Cc: lkp@intel.com, Julia Lawall Subject: [PATCH] drm: fix device_node_continue.cocci warnings CC: kbuild-all@lists.01.org BCC: lkp@intel.com CC: Linux Memory Management List TO: Paul Kocialkowski CC: Maxime Ripard CC: David Airlie CC: Daniel Vetter CC: dri-devel@lists.freedesktop.org CC: linux-kernel@vger.kernel.org From: kernel test robot drivers/gpu/drm/logicvc/logicvc_layer.c:616:2-13: ERROR: probable double put. Device node iterators put the previous value of the index variable, so an explicit put causes a double put. Generated by: scripts/coccinelle/iterators/device_node_continue.cocci Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 6d0c806803170f120f8cb97b321de7bd89d3a791 commit: efeeaefe9be56e8ae5e5b4e9ff6d2275ec977ec5 [2027/2566] drm: Add support for the LogiCVC display controller :::::: branch date: 17 hours ago :::::: commit date: 31 hours ago Please take the patch only if it's a positive warning. Thanks! drivers/gpu/drm/logicvc/logicvc_layer.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/gpu/drm/logicvc/logicvc_layer.c +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c @@ -612,8 +612,6 @@ int logicvc_layers_init(struct logicvc_d ret = logicvc_layer_init(logicvc, layer_node, index); if (ret) goto error; - - of_node_put(layer_node); } of_node_put(layers_node);