From patchwork Tue May 23 00:14:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 9741677 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7B37A60210 for ; Tue, 23 May 2017 01:03:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6CFAD2877A for ; Tue, 23 May 2017 01:03:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6068728780; Tue, 23 May 2017 01:03:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 698CB2877A for ; Tue, 23 May 2017 01:03:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B8186E2FA; Tue, 23 May 2017 01:01:39 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lf0-x241.google.com (mail-lf0-x241.google.com [IPv6:2a00:1450:4010:c07::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6145B89CA1 for ; Tue, 23 May 2017 00:15:23 +0000 (UTC) Received: by mail-lf0-x241.google.com with SMTP id 99so6669514lfu.2 for ; Mon, 22 May 2017 17:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=ktcDIOlimEPBWnIXHIsJEz44fph0l9FnkgjebrjzuR8=; b=LTjdeOeSDBBumcx+thNbkLKYaLraTl6Rp0As1MLqQ4LkGNOt8148iJbgSbkBLtwtVo KfIQnM4GTEtULZ/35NMph+3XRS5ac3o9cYwM6tQTLve9d71h2RE/A5WsbZMKXC6m0o4R xmkygLeAJFnj0qX0Q1VqKjVxeqtaCHMo/4VAUdhPdY3+N8sz6+SOwhZo/m8x99D6pk1m 8+Yw6KC/3KS+7yxewBVeYOFR2/syryOjQN0Z44uyf5qINa1gqazotrfTtqerYHxcy1hX QojOF6Knz2XUm4uhcTmbUfh9Ep8QfYttjGtInrR997xXsmP4XxEDbF7kZemh/BQO0VI1 9GtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=ktcDIOlimEPBWnIXHIsJEz44fph0l9FnkgjebrjzuR8=; b=RzYJFWzhzFWE7H3vjTFawzygmZfNwuqIOyPUGWrmdB4SNgrfMush+o8z5KsrrFFZSd 2VlUjsc/ChsIhM8tIhg//NhXY1nBv7aPnUyTsmqMTI5XA8AWiqNacoCoWuiHrR/enZkM YCvvvYO3YE97yqSI12+317vewZVEDJc7wdU2r/3KnlJzerP4a3FmPdfIBeOqBnRKqbRn 26VkZXxgtlfQbKrAhMMRpyTVq27hoCgauwo0OyzkTfi1lGym67tPsUlL8ClWEX3jFV8L GjhD0poSG+Vsxxw+RBPvErNvXYJPsZhLH+7fWcq9M942dyeCUd+tqMjo96T5d0OZP6h+ 35fw== X-Gm-Message-State: AODbwcCXEgIps6An/zXKEVlw6SdgUhSzF4W9Tt3U5t4qNyI0Ho6etnCW IF/fdZgIFgb7MA== X-Received: by 10.25.162.133 with SMTP id l127mr5867454lfe.99.1495498521847; Mon, 22 May 2017 17:15:21 -0700 (PDT) Received: from localhost.localdomain (ppp109-252-91-175.pppoe.spdop.ru. [109.252.91.175]) by smtp.gmail.com with ESMTPSA id v30sm3440904ljd.9.2017.05.22.17.15.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 May 2017 17:15:21 -0700 (PDT) From: Dmitry Osipenko To: Thierry Reding , Mikko Perttunen Subject: [PATCH 07/22] drm/tegra: Remove module ownership from the tegra_fb_ops Date: Tue, 23 May 2017 03:14:22 +0300 Message-Id: X-Mailer: git-send-email 2.13.0 In-Reply-To: References: In-Reply-To: References: X-Mailman-Approved-At: Tue, 23 May 2017 00:59:38 +0000 Cc: linux-tegra@vger.kernel.org, DRI Development X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP The framebuffers console fbcon_startup() increments the tegra_drm module 'use' refcount via try_module_get(), causing an interlock of the DRM subsys and the tegra_drm modules. In result, the tegra_drm module can't be unloaded using rmmod. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c index 25acb73ee728..75e102ffdc86 100644 --- a/drivers/gpu/drm/tegra/fb.c +++ b/drivers/gpu/drm/tegra/fb.c @@ -202,7 +202,6 @@ struct drm_framebuffer *tegra_fb_create(struct drm_device *drm, #ifdef CONFIG_DRM_FBDEV_EMULATION static struct fb_ops tegra_fb_ops = { - .owner = THIS_MODULE, DRM_FB_HELPER_DEFAULT_OPS, .fb_fillrect = drm_fb_helper_sys_fillrect, .fb_copyarea = drm_fb_helper_sys_copyarea,