From patchwork Tue Oct 24 13:59:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 10024645 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4AA0360245 for ; Tue, 24 Oct 2017 13:59:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4098D27F91 for ; Tue, 24 Oct 2017 13:59:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 34EBA283F9; Tue, 24 Oct 2017 13:59:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C6BC027F91 for ; Tue, 24 Oct 2017 13:59:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2DC5B6E4D6; Tue, 24 Oct 2017 13:59:29 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.web.de (mout.web.de [212.227.17.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id CF0EB6E4D6; Tue, 24 Oct 2017 13:59:27 +0000 (UTC) Received: from [192.168.1.2] ([92.227.117.134]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0Lk8ko-1dVBwj0XGc-00c5g8; Tue, 24 Oct 2017 15:59:19 +0200 Subject: [PATCH 1/2] drm/i915/dp: Delete an unnecessary goto statement in intel_dp_sink_crc() From: SF Markus Elfring To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, David Airlie , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi References: <668a4b56-091d-d4e7-2204-daaec6675e11@users.sourceforge.net> Message-ID: Date: Tue, 24 Oct 2017 15:59:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <668a4b56-091d-d4e7-2204-daaec6675e11@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:/fQJ+TaGB1flD2HL99eNIjO1/asL6RYgoTI5JiFY9314HcwE+qU UhFMs4hLHX4tOM+TQTrHpVvk5rjo5jAVCP198KsW/4QFn1ghWgd0l4MWzpN3kG1vbLgTs0u Z2vuSszpwXbDt6eubzU6bQkkaKHIHBcLlPQxuQGofPjIXQ5FlHDfpCh60HVn2DuImF4bdDE q04qTcZh5mkuKAfYO5Tjg== X-UI-Out-Filterresults: notjunk:1; V01:K0:zLw6wF5s+fA=:9Dfq73gaoCHR6QnjdfDXfy f8OyG8TtFeoczI2mHN+G8U5cIXACMF/MoPyMJPF73soXBgdvacjxO9sGq7bwbaDnkg18VZagf G/6qCCUo9WMYKlbuiGj9n7mpcqt+b43Y2Z3m4veP9qvm9N633IC3aTNDBwGzqr81+QxbB983g /klaPtE6V9rZVV//b8kVUwQOglaFmm2TxxphFMj231q5PfO9UkN+/mbSFQq8jofoxfOadDu3N 7lyJy2lPoxuax0UQqL3mwbTTuE9iOBgfycTyauLVlp54kyrrXej3to7KAhnpmyXhTRZOO4/tI ju4pqcAu9VJxraH9etFgDCptdmNFbTPFSRS7oNFtMNk5Qo+IXmRllCRastxIQkANia8cGdduQ g4xPMXJvEXk90guXk/Geb/o14N3I70UnflNcos2NhTCimdkyFnn95ekQkp94/J/Sg+1rBsQrP MgrkI+ndLVAf/tkUJ3hAyd4RRLMJPlkRr+Mk2Vky90N6pGOkdJz6GxpNX8+9+i4BiFAvgVuv/ F7PV45oNYN43mnZShcT9h1xcW2j52+XqUrVQSrjddIaSKZGJK/yg1Ax7OaFA5pmeflJCzgMpQ sbGb+/Ps/wrt8cD53z201Qbwa/4TTuDGHsrD2UnrKdfs8722FN7Dh54f+bLh/IiDwuNCYfaEv Hw2mXwWc/OOh/Q2TgYfqlraQ5RLV1EUcOy/AXzbj7vpdVzbopS4u3dJ+A7fUlscLzLDX+lRpv /0r1Ak+vAOZZmqp4s9dhPyL2rQZt3I4jxUH01fVAGMMLsWe0wiwgEvCewdPQyGf86Cfp76YH/ VTQotLbfixVxR3UzIKN8UPswiyrvbTPWMJoedFO3hSmidOTZcg= Cc: kernel-janitors@vger.kernel.org, LKML X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Tue, 24 Oct 2017 15:15:20 +0200 A jump was specified for a location which was directly behind. Thus remove such an unnecessary goto statement. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/i915/intel_dp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index ca48bce23a6f..342f1a1fa085 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -3994,10 +3994,8 @@ int intel_dp_sink_crc(struct intel_dp *intel_dp, u8 *crc) goto stop; } - if (drm_dp_dpcd_read(&intel_dp->aux, DP_TEST_CRC_R_CR, crc, 6) < 0) { + if (drm_dp_dpcd_read(&intel_dp->aux, DP_TEST_CRC_R_CR, crc, 6) < 0) ret = -EIO; - goto stop; - } stop: intel_dp_sink_crc_stop(intel_dp);