From patchwork Tue May 2 20:10:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9708557 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 912E360349 for ; Tue, 2 May 2017 20:10:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 83297206AC for ; Tue, 2 May 2017 20:10:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 77AF02815E; Tue, 2 May 2017 20:10:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 18F68206AC for ; Tue, 2 May 2017 20:10:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2F2BD6E24B; Tue, 2 May 2017 20:10:18 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.web.de (mout.web.de [212.227.17.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 96D996E24B; Tue, 2 May 2017 20:10:16 +0000 (UTC) Received: from [192.168.1.2] ([77.182.79.197]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MFLB2-1dJvKX42su-00EL3Y; Tue, 02 May 2017 22:10:10 +0200 Subject: [PATCH 3/3] GPU-DRM-Radeon: Use seq_puts() in r100_debugfs_cp_csq_fifo() From: SF Markus Elfring To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , David Airlie References: <74d2df52-f509-e6d2-5b35-e25b7cbd1fbe@users.sourceforge.net> Message-ID: Date: Tue, 2 May 2017 22:10:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <74d2df52-f509-e6d2-5b35-e25b7cbd1fbe@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:vc7VhrJgXZHXoig+2pFvVQfQX9q2Us8zf07SxHX/c2kfGvCenRr uheNqovJe+uMIPTx1/UkfSr77LNiv8iQS8YKebVX8KpiohJlMqFp+rcxY/YeAHTzgRPMXaq 0Nctg8DR5kkA4Okd562ukKBV6o5JC7Tiofccpo2zbHetSlI1b6PBu0j7EiOfcNFj17uuPTG PNGaRme0PEjrnVUwqFYOQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:Co6G9X6F7Ns=:KFxem5XezDXsqjxfmkFxuj YrLBViTU328Vyvt3Ab+D3YPn6LE/GNZ/ukfiXrKEyr0qL9xb20I6GGg7AAxUsGfZ7B/YVv0jz 9OYDWdMqkfIY7tpvNmZBvbcwswUjzqwbQwa0XE2AyYuPktOs7JXHTpYppmFu7SkdDZUmFRve8 F2efzMStNf45PquOHblv7po3GPhhHjIWkmsApF0oQDvZAywh7JrEWkg6d7pij8DouI4Iud604 oWKtREPA5UuVkulQc7JHy1yBoYVmqJcilivHAeSzZ3+0KwFScCJlHX5l25zx3OFC8rC+CxUrq YmIy6f55VkFr/9CBhZTr0QTMJVRcWnMLOajcShXbBoE0EUpRGHi6J27okuFeLnSR6y5KfzfnK qbxhYlZ9RetFR3Qedy0VjVM4gDEXVgwy8h5HsNyvVJ4hDdqiQgJ8QVdiAnAwTjhRdUCY67ps3 asLYBHWPOELO5bMIgmS5lt60qLnhKOQUc8tNv7qgRnywHkS2e6AeTOMoIxRcULzfNf/U0MZH1 5vdD9Ay+1BnGJrQkRmn3qvpBpiAw4H18NnOlyOYIqZ0VJHoD0aVh1sJ3A1Z6e5Oo0jTMDbOHZ AoNb5mL1FT2H1fiX0TANBOY9BXejGGdoEK/ZqeR8RfsOJWRHBl63JochENpFOOq8Zk2zGbyGq jbYB8Byjde6dtPV79uKqnQ/ed2+jshRYZSGPM+cKQhivyQciMhe6L5JfbXW5A9kPUGC8vVJJk lg/tGsPhdhlyDSApJuGf8Dt7Fo5KEWrAw74rffpZI0a+kv2bM+jfWOon8d2uwI65BvdniLMqK fKyug2x Cc: kernel-janitors@vger.kernel.org, LKML X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Tue, 2 May 2017 21:54:49 +0200 Strings which did not contain data format specifications should be put into a sequence. Thus use the corresponding function "seq_puts". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/radeon/r100.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c index c31e660e35db..09b88738aa07 100644 --- a/drivers/gpu/drm/radeon/r100.c +++ b/drivers/gpu/drm/radeon/r100.c @@ -2992,19 +2992,19 @@ static int r100_debugfs_cp_csq_fifo(struct seq_file *m, void *data) seq_printf(m, "Indirect2 wptr %u\n", ib2_wptr); /* FIXME: 0, 128, 640 depends on fifo setup see cp_init_kms * 128 = indirect1_start * 8 & 640 = indirect2_start * 8 */ - seq_printf(m, "Ring fifo:\n"); + seq_puts(m, "Ring fifo:\n"); for (i = 0; i < 256; i++) { WREG32(RADEON_CP_CSQ_ADDR, i << 2); tmp = RREG32(RADEON_CP_CSQ_DATA); seq_printf(m, "rfifo[%04d]=0x%08X\n", i, tmp); } - seq_printf(m, "Indirect1 fifo:\n"); + seq_puts(m, "Indirect1 fifo:\n"); for (i = 256; i <= 512; i++) { WREG32(RADEON_CP_CSQ_ADDR, i << 2); tmp = RREG32(RADEON_CP_CSQ_DATA); seq_printf(m, "ib1fifo[%04d]=0x%08X\n", i, tmp); } - seq_printf(m, "Indirect2 fifo:\n"); + seq_puts(m, "Indirect2 fifo:\n"); for (i = 640; i < ib1_wptr; i++) { WREG32(RADEON_CP_CSQ_ADDR, i << 2); tmp = RREG32(RADEON_CP_CSQ_DATA);