diff mbox series

[3/3] drm: rcar-du: DRM_RCAR_MIPI_DSI should depend on ARCH_RENESAS

Message ID c8599f5ba4f281a71240b3d6a8f27f450dfb5d17.1639559338.git.geert+renesas@glider.be (mailing list archive)
State New, archived
Headers show
Series drm: rcar-du: Add missing dependencies | expand

Commit Message

Geert Uytterhoeven Dec. 15, 2021, 9:27 a.m. UTC
The Renesas R-Car Display Unit embedded MIPI DSI encoder is only present
on Renesas R-Car V3U SoCs.  Hence add a dependency on ARCH_RENESAS, to
prevent asking the user about this driver when configuring a kernel
without Renesas SoC support.

Fixes: 155358310f013c23 ("drm: rcar-du: Add R-Car DSI driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/gpu/drm/rcar-du/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Laurent Pinchart Dec. 15, 2021, 10:25 a.m. UTC | #1
Hi Geert,

Thank you for the patch.

On Wed, Dec 15, 2021 at 10:27:47AM +0100, Geert Uytterhoeven wrote:
> The Renesas R-Car Display Unit embedded MIPI DSI encoder is only present
> on Renesas R-Car V3U SoCs.  Hence add a dependency on ARCH_RENESAS, to
> prevent asking the user about this driver when configuring a kernel
> without Renesas SoC support.
> 
> Fixes: 155358310f013c23 ("drm: rcar-du: Add R-Car DSI driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/gpu/drm/rcar-du/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
> index a7aa556e301d1087..2f4f6ac5fd4e66b1 100644
> --- a/drivers/gpu/drm/rcar-du/Kconfig
> +++ b/drivers/gpu/drm/rcar-du/Kconfig
> @@ -48,6 +48,7 @@ config DRM_RCAR_LVDS
>  config DRM_RCAR_MIPI_DSI
>  	tristate "R-Car DU MIPI DSI Encoder Support"
>  	depends on DRM && DRM_BRIDGE && OF
> +	depends on ARCH_RENESAS || COMPILE_TEST

Same as for 1/3, let's move this entry first. I can handle this when
applying the patches, I'll take 1/3 and 3/3 in my tree already.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  	select DRM_MIPI_DSI
>  	help
>  	  Enable support for the R-Car Display Unit embedded MIPI DSI encoders.
Laurent Pinchart Dec. 15, 2021, 10:29 a.m. UTC | #2
On Wed, Dec 15, 2021 at 12:25:26PM +0200, Laurent Pinchart wrote:
> Hi Geert,
> 
> Thank you for the patch.
> 
> On Wed, Dec 15, 2021 at 10:27:47AM +0100, Geert Uytterhoeven wrote:
> > The Renesas R-Car Display Unit embedded MIPI DSI encoder is only present
> > on Renesas R-Car V3U SoCs.  Hence add a dependency on ARCH_RENESAS, to
> > prevent asking the user about this driver when configuring a kernel
> > without Renesas SoC support.
> > 
> > Fixes: 155358310f013c23 ("drm: rcar-du: Add R-Car DSI driver")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >  drivers/gpu/drm/rcar-du/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
> > index a7aa556e301d1087..2f4f6ac5fd4e66b1 100644
> > --- a/drivers/gpu/drm/rcar-du/Kconfig
> > +++ b/drivers/gpu/drm/rcar-du/Kconfig
> > @@ -48,6 +48,7 @@ config DRM_RCAR_LVDS
> >  config DRM_RCAR_MIPI_DSI
> >  	tristate "R-Car DU MIPI DSI Encoder Support"
> >  	depends on DRM && DRM_BRIDGE && OF
> > +	depends on ARCH_RENESAS || COMPILE_TEST
> 
> Same as for 1/3, let's move this entry first. I can handle this when
> applying the patches, I'll take 1/3 and 3/3 in my tree already.

Actually, if we wrap all subdrivers in 'if DRM_RCAR_DU', we won't need
1/3 and 3/3. Let's reach a conclusion on that topic first.

> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> >  	select DRM_MIPI_DSI
> >  	help
> >  	  Enable support for the R-Car Display Unit embedded MIPI DSI encoders.
diff mbox series

Patch

diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
index a7aa556e301d1087..2f4f6ac5fd4e66b1 100644
--- a/drivers/gpu/drm/rcar-du/Kconfig
+++ b/drivers/gpu/drm/rcar-du/Kconfig
@@ -48,6 +48,7 @@  config DRM_RCAR_LVDS
 config DRM_RCAR_MIPI_DSI
 	tristate "R-Car DU MIPI DSI Encoder Support"
 	depends on DRM && DRM_BRIDGE && OF
+	depends on ARCH_RENESAS || COMPILE_TEST
 	select DRM_MIPI_DSI
 	help
 	  Enable support for the R-Car Display Unit embedded MIPI DSI encoders.