| Message ID | d0f63518a053a817cec0ad0e7d9241f9eb2a4a8e.1731689044.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] drm/i2c: tda9950: Constify struct i2c_device_id | expand |
Am 15.11.24 um 18:17 schrieb Christophe JAILLET: > 'struct i2c_device_id' is not modified in this driver. > > Constifying this structure moves some data to a read-only section, so > increase overall security. > > On a x86_64, with allmodconfig: > Before: > ====== > text data bss dec hex filename > 12136 822 0 12958 329e drivers/gpu/drm/i2c/tda9950.o > > After: > ===== > text data bss dec hex filename > 12200 758 0 12958 329e drivers/gpu/drm/i2c/tda9950.o > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > Compile tested-only. > > v2: fix missing const :( > --- > drivers/gpu/drm/i2c/tda9950.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i2c/tda9950.c b/drivers/gpu/drm/i2c/tda9950.c > index 82d618c40dce..5065d6212fe4 100644 > --- a/drivers/gpu/drm/i2c/tda9950.c > +++ b/drivers/gpu/drm/i2c/tda9950.c > @@ -485,7 +485,7 @@ static void tda9950_remove(struct i2c_client *client) > cec_unregister_adapter(priv->adap); > } > > -static struct i2c_device_id tda9950_ids[] = { > +static const struct i2c_device_id tda9950_ids[] = { > { "tda9950", 0 }, > { }, > };
diff --git a/drivers/gpu/drm/i2c/tda9950.c b/drivers/gpu/drm/i2c/tda9950.c index 82d618c40dce..5065d6212fe4 100644 --- a/drivers/gpu/drm/i2c/tda9950.c +++ b/drivers/gpu/drm/i2c/tda9950.c @@ -485,7 +485,7 @@ static void tda9950_remove(struct i2c_client *client) cec_unregister_adapter(priv->adap); } -static struct i2c_device_id tda9950_ids[] = { +static const struct i2c_device_id tda9950_ids[] = { { "tda9950", 0 }, { }, };
'struct i2c_device_id' is not modified in this driver. Constifying this structure moves some data to a read-only section, so increase overall security. On a x86_64, with allmodconfig: Before: ====== text data bss dec hex filename 12136 822 0 12958 329e drivers/gpu/drm/i2c/tda9950.o After: ===== text data bss dec hex filename 12200 758 0 12958 329e drivers/gpu/drm/i2c/tda9950.o Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- Compile tested-only. v2: fix missing const :( --- drivers/gpu/drm/i2c/tda9950.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)