diff mbox series

drm: virtio: fix kconfig dependency warning

Message ID d3643dcf-87f4-ff45-fb90-9945458438f9@infradead.org (mailing list archive)
State New, archived
Headers show
Series drm: virtio: fix kconfig dependency warning | expand

Commit Message

Randy Dunlap Aug. 26, 2020, 4:47 p.m. UTC 
From: Randy Dunlap <rdunlap@infradead.org>

Fix kconfig dependency warning by using a different Kconfig symbol.

WARNING: unmet direct dependencies detected for VIRTIO_DMA_SHARED_BUFFER
  Depends on [n]: VIRTIO_MENU [=n] && DMA_SHARED_BUFFER [=y]
  Selected by [y]:
  - DRM_VIRTIO_GPU [=y] && HAS_IOMEM [=y] && DRM [=y] && VIRTIO [=y] && MMU [=y]

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: David Airlie <airlied@linux.ie>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: dri-devel@lists.freedesktop.org
Cc: virtualization@lists.linux-foundation.org
---
Found in linux-next but applies to mainline.

 drivers/gpu/drm/virtio/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gerd Hoffmann Aug. 28, 2020, 11:25 a.m. UTC | #1 
Hi,

>  config DRM_VIRTIO_GPU
>  	tristate "Virtio GPU driver"
> -	depends on DRM && VIRTIO && MMU
> +	depends on DRM && VIRTIO_MENU && MMU

Shouldn't this depend on both VIRTIO and VIRTIO_MENU, simliar to the
other virtio drivers?

take care,
  Gerd
Randy Dunlap Aug. 28, 2020, 2:01 p.m. UTC | #2 
On 8/28/20 4:25 AM, Gerd Hoffmann wrote:
>   Hi,
> 
>>  config DRM_VIRTIO_GPU
>>  	tristate "Virtio GPU driver"
>> -	depends on DRM && VIRTIO && MMU
>> +	depends on DRM && VIRTIO_MENU && MMU
> 
> Shouldn't this depend on both VIRTIO and VIRTIO_MENU, simliar to the
> other virtio drivers?

OK, I'll send a v2.

thanks.
diff mbox series

Patch

--- linux-next-20200826.orig/drivers/gpu/drm/virtio/Kconfig
+++ linux-next-20200826/drivers/gpu/drm/virtio/Kconfig
@@ -1,7 +1,7 @@ 
 # SPDX-License-Identifier: GPL-2.0-only
 config DRM_VIRTIO_GPU
 	tristate "Virtio GPU driver"
-	depends on DRM && VIRTIO && MMU
+	depends on DRM && VIRTIO_MENU && MMU
 	select DRM_KMS_HELPER
 	select DRM_GEM_SHMEM_HELPER
 	select VIRTIO_DMA_SHARED_BUFFER