| Message ID | e03e7106-0f22-99c4-ad21-b288e8990b5a@web.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | gpu/drm: ingenic: Delete an error message in ingenic_drm_probe() | expand |
Hi Markus, Le dim. 5 avril 2020 à 11:30, Markus Elfring <Markus.Elfring@web.de> a écrit : > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 5 Apr 2020 11:25:30 +0200 > > The function “platform_get_irq” can log an error already. > Thus omit a redundant message for the exception handling in the > calling function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Applied to drm-misc-next, thanks. -Paul > --- > drivers/gpu/drm/ingenic/ingenic-drm.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c > b/drivers/gpu/drm/ingenic/ingenic-drm.c > index 9dfe7cb530e1..06ca752b76ee 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c > @@ -661,10 +661,8 @@ static int ingenic_drm_probe(struct > platform_device *pdev) > } > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "Failed to get platform irq"); > + if (irq < 0) > return irq; > - } > > if (soc_info->needs_dev_clk) { > priv->lcd_clk = devm_clk_get(dev, "lcd"); > -- > 2.26.0 >
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm.c index 9dfe7cb530e1..06ca752b76ee 100644 --- a/drivers/gpu/drm/ingenic/ingenic-drm.c +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c @@ -661,10 +661,8 @@ static int ingenic_drm_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "Failed to get platform irq"); + if (irq < 0) return irq; - } if (soc_info->needs_dev_clk) { priv->lcd_clk = devm_clk_get(dev, "lcd");