did the drm patch to support Iris(TM) Graphics P555 fell through the cracks? (Was: Re: [Intel-gfx] RFC: libdrm: Support Iris Graphics 540 & 550 (Skylake GT3e))

Commit Message

Thorsten Leemhuis May 31, 2016, 11:12 a.m. UTC

CCing danvet

Thorsten Leemhuis wrote on 28.04.2016 10:37:
> Kenneth Graunke wrote on 28.04.2016 03:05:
>> On Wednesday, April 27, 2016 9:37:07 AM PDT Thorsten Leemhuis wrote:
>>> Thorsten Leemhuis wrote on 26.04.2016 13:41:
>>> Forget that patch -- a way better one was submitted weeks ago my Michal
>>> already:
>>> https://lists.freedesktop.org/archives/intel-gfx/2016-February/087819.html
>> It looks like it fell through the cracks.  Roland just mentioned this on
>> IRC...I've reviewed and pushed the patch to master.  I'm also making a
>> release.
> Many thx. Side note, while at it: I think this linux-drm patch from
> Michał fell through the cracks, too:
> https://lists.freedesktop.org/archives/intel-gfx/2016-February/087855.html

Quote from that linux-drm patch
"""
Used by production device:
    Intel(R) Iris(TM) Graphics P555
"""
A Xeon processor with said gpu is now available afaics:
http://ark.intel.com/products/93847/Intel-Xeon-Processor-E3-1558L-v5-8M-Cache-1_90-GHz

> Whole story:  That libdrm patch you applied contained this line:
> +#define PCI_CHIP_SKYLAKE_SRV_GT3 0x192D
> This id for the Iris Graphics P555 is also present in Mesa master
> i965(¹), but missing in Linux master afaics:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/drm/i915_pciids.h#n279
> And it's not in drm-intel-next either afaics:
> https://cgit.freedesktop.org/drm-intel/tree/include/drm/i915_pciids.h?h=drm-intel-next#n279

That patch (see below) afaics still wasn't applied; and it's not in
drm-intel-next-queued either. I'm wondering if there is a reason why it
wasn't merged or if it is another oversight :-/

CU, knurd

P.S.: FWIW, here is the content from
https://lists.freedesktop.org/archives/intel-gfx/2016-February/087855.html :
"""
Used by production device:
    Intel(R) Iris(TM) Graphics P555

Signed-off-by: Michał Winiarski <michal.winiarski at intel.com>
---
 include/drm/i915_pciids.h | 1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index 9094599..9266c2c 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -281,6 +281,7 @@ 
 	INTEL_VGA_DEVICE(0x1926, info), /* ULT GT3 */ \
 	INTEL_VGA_DEVICE(0x1927, info), /* ULT GT3 */ \
 	INTEL_VGA_DEVICE(0x192B, info), /* Halo GT3 */ \
+	INTEL_VGA_DEVICE(0x192D, info), /* SRV GT3 */ \
 	INTEL_VGA_DEVICE(0x192A, info)  /* SRV GT3 */

 #define INTEL_SKL_GT4_IDS(info) \