From patchwork Tue May 31 11:12:19 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thorsten Leemhuis X-Patchwork-Id: 9144759 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3C5DF60752 for ; Tue, 31 May 2016 12:55:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2F894272D8 for ; Tue, 31 May 2016 12:55:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2470F27D17; Tue, 31 May 2016 12:55:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1DA2D272D8 for ; Tue, 31 May 2016 12:55:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 121B96E570; Tue, 31 May 2016 12:55:47 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from basicbox7.server-home.net (basicbox7.server-home.net [195.137.212.29]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2AE766E424; Tue, 31 May 2016 11:12:23 +0000 (UTC) Received: from thl.ct.heise.de (gatekeeper.heise.de [193.99.145.162]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by basicbox7.server-home.net (Postfix) with ESMTPSA id BA9625EE7CB; Tue, 31 May 2016 13:12:20 +0200 (CEST) Subject: did the drm patch to support Iris(TM) Graphics P555 fell through the cracks? (Was: Re: [Intel-gfx] RFC: libdrm: Support Iris Graphics 540 & 550 (Skylake GT3e)) To: Kenneth Graunke , intel-gfx@lists.freedesktop.org References: <43a15a30-5a5a-07cf-2bc2-504798af0728@leemhuis.info> <1657484.Me4DBK0g4j@eiger> From: Thorsten Leemhuis Message-ID: Date: Tue, 31 May 2016 13:12:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: X-Mailman-Approved-At: Tue, 31 May 2016 12:54:41 +0000 Cc: daniel.vetter@ffwll.ch, Emil Velikov , dri-devel@lists.freedesktop.org, Ben Widawsky X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP CCing danvet Thorsten Leemhuis wrote on 28.04.2016 10:37: > Kenneth Graunke wrote on 28.04.2016 03:05: >> On Wednesday, April 27, 2016 9:37:07 AM PDT Thorsten Leemhuis wrote: >>> Thorsten Leemhuis wrote on 26.04.2016 13:41: >>> Forget that patch -- a way better one was submitted weeks ago my Michal >>> already: >>> https://lists.freedesktop.org/archives/intel-gfx/2016-February/087819.html >> It looks like it fell through the cracks. Roland just mentioned this on >> IRC...I've reviewed and pushed the patch to master. I'm also making a >> release. > Many thx. Side note, while at it: I think this linux-drm patch from > Michał fell through the cracks, too: > https://lists.freedesktop.org/archives/intel-gfx/2016-February/087855.html Quote from that linux-drm patch """ Used by production device: Intel(R) Iris(TM) Graphics P555 """ A Xeon processor with said gpu is now available afaics: http://ark.intel.com/products/93847/Intel-Xeon-Processor-E3-1558L-v5-8M-Cache-1_90-GHz > Whole story: That libdrm patch you applied contained this line: > +#define PCI_CHIP_SKYLAKE_SRV_GT3 0x192D > This id for the Iris Graphics P555 is also present in Mesa master > i965(¹), but missing in Linux master afaics: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/drm/i915_pciids.h#n279 > And it's not in drm-intel-next either afaics: > https://cgit.freedesktop.org/drm-intel/tree/include/drm/i915_pciids.h?h=drm-intel-next#n279 That patch (see below) afaics still wasn't applied; and it's not in drm-intel-next-queued either. I'm wondering if there is a reason why it wasn't merged or if it is another oversight :-/ CU, knurd P.S.: FWIW, here is the content from https://lists.freedesktop.org/archives/intel-gfx/2016-February/087855.html : """ Used by production device: Intel(R) Iris(TM) Graphics P555 Signed-off-by: Michał Winiarski --- include/drm/i915_pciids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index 9094599..9266c2c 100644 --- a/include/drm/i915_pciids.h +++ b/include/drm/i915_pciids.h @@ -281,6 +281,7 @@ INTEL_VGA_DEVICE(0x1926, info), /* ULT GT3 */ \ INTEL_VGA_DEVICE(0x1927, info), /* ULT GT3 */ \ INTEL_VGA_DEVICE(0x192B, info), /* Halo GT3 */ \ + INTEL_VGA_DEVICE(0x192D, info), /* SRV GT3 */ \ INTEL_VGA_DEVICE(0x192A, info) /* SRV GT3 */ #define INTEL_SKL_GT4_IDS(info) \