| Message ID | fbfe7651-b0d1-0530-43d8-858903d9389f@xs4all.nl (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2017-07-17 13:50 GMT+02:00 Hans Verkuil <hverkuil@xs4all.nl>: > If the stih-cec driver is a module and the drm sti driver is built-in, then > the CEC core will be a module also, causing the CEC notifier to fail (will be > compiled as empty functions). > > To prevent this select CEC_CORE if CEC_NOTIFIER is set to ensure the CEC core > is also built into the kernel. > > Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Thanks, Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> > --- > diff --git a/drivers/gpu/drm/sti/Kconfig b/drivers/gpu/drm/sti/Kconfig > index acd72865feac..0eab3cb59fc5 100644 > --- a/drivers/gpu/drm/sti/Kconfig > +++ b/drivers/gpu/drm/sti/Kconfig > @@ -8,5 +8,6 @@ config DRM_STI > select DRM_PANEL > select FW_LOADER > select SND_SOC_HDMI_CODEC if SND_SOC > + select CEC_CORE if CEC_NOTIFIER > help > Choose this option to enable DRM on STM stiH4xx chipset
diff --git a/drivers/gpu/drm/sti/Kconfig b/drivers/gpu/drm/sti/Kconfig index acd72865feac..0eab3cb59fc5 100644 --- a/drivers/gpu/drm/sti/Kconfig +++ b/drivers/gpu/drm/sti/Kconfig @@ -8,5 +8,6 @@ config DRM_STI select DRM_PANEL select FW_LOADER select SND_SOC_HDMI_CODEC if SND_SOC + select CEC_CORE if CEC_NOTIFIER help Choose this option to enable DRM on STM stiH4xx chipset
If the stih-cec driver is a module and the drm sti driver is built-in, then the CEC core will be a module also, causing the CEC notifier to fail (will be compiled as empty functions). To prevent this select CEC_CORE if CEC_NOTIFIER is set to ensure the CEC core is also built into the kernel. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> ---