| Message ID | fd28a9cec24a8d32ebb26dd857c399d0a15acdd5.1628188477.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/amd/pm: Fix a memory leak in an error handling path in 'vangogh_tables_init()' | expand |
Applied. Thanks! Alex On Thu, Aug 5, 2021 at 2:44 PM Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > > 'watermarks_table' must be freed instead 'clocks_table', because > 'clocks_table' is known to be NULL at this point and 'watermarks_table' is > never freed if the last kzalloc fails. > > Fixes: c98ee89736b8 ("drm/amd/pm: add the fine grain tuning function for vangogh") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > index 335b3c70e1a7..06eea917284e 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > @@ -256,7 +256,7 @@ static int vangogh_tables_init(struct smu_context *smu) > return 0; > > err3_out: > - kfree(smu_table->clocks_table); > + kfree(smu_table->watermarks_table); > err2_out: > kfree(smu_table->gpu_metrics_table); > err1_out: > -- > 2.30.2 >
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c index 335b3c70e1a7..06eea917284e 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c @@ -256,7 +256,7 @@ static int vangogh_tables_init(struct smu_context *smu) return 0; err3_out: - kfree(smu_table->clocks_table); + kfree(smu_table->watermarks_table); err2_out: kfree(smu_table->gpu_metrics_table); err1_out:
'watermarks_table' must be freed instead 'clocks_table', because 'clocks_table' is known to be NULL at this point and 'watermarks_table' is never freed if the last kzalloc fails. Fixes: c98ee89736b8 ("drm/amd/pm: add the fine grain tuning function for vangogh") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)