diff mbox series

[1/3] tls: Use l_put_be64 for IV creation in case of AEAD ciphers

Message ID 20230103144000.641471-1-marcel@holtmann.org (mailing list archive)
State New
Headers show
Series [1/3] tls: Use l_put_be64 for IV creation in case of AEAD ciphers | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
prestwoj/iwd-ci-build success Build - Configure
prestwoj/iwd-ci-clang success clang PASS
prestwoj/iwd-ci-makecheckvalgrind success Make Check w/Valgrind
prestwoj/iwd-ci-makecheck success Make Check
prestwoj/iwd-ci-makedistcheck success Make Distcheck
prestwoj/iwd-ci-testrunner success test-runner PASS

Commit Message

Marcel Holtmann Jan. 3, 2023, 2:39 p.m. UTC 
The usage of l_put_le64 for encryption ciphers seems weird since
normally all its input is big endian. So change this here to also use
big endian version to store the sequence number.
---
 ell/tls-record.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/ell/tls-record.c b/ell/tls-record.c
index cdbd0b8040bb..6ac095629abe 100644
--- a/ell/tls-record.c
+++ b/ell/tls-record.c
@@ -177,7 +177,7 @@  static void tls_tx_record_plaintext(struct l_tls *tls,
 		 * be used to build the IV.
 		 */
 		memcpy(iv, tls->fixed_iv[1], tls->fixed_iv_length[1]);
-		l_put_le64(tls->seq_num[1], iv + tls->fixed_iv_length[1]);
+		l_put_be64(tls->seq_num[1], iv + tls->fixed_iv_length[1]);
 
 		if (tls->record_iv_length[1] > 8)
 			memset(iv + tls->fixed_iv_length[1] + 8, 42,