| Message ID | 20231121184836.197219-1-marcel@holtmann.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | netlink: Add workaround for missing NLM_F_ACK_TLVS and NLM_F_CAPPED | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| prestwoj/iwd-ci-makedistcheck | success | Make Distcheck |
| prestwoj/iwd-ci-build | success | Build - Configure |
| prestwoj/iwd-ci-makecheck | success | Make Check |
| prestwoj/iwd-ci-makecheckvalgrind | success | Make Check w/Valgrind |
| prestwoj/iwd-ci-clang | success | clang PASS |
| prestwoj/iwd-ci-testrunner | success | test-runner PASS |
Hi, > The feature for NETLINK_EXT_ACK also adds two additional flags. These > are NLM_F_ACK_TLVS and NLM_F_CAPPED and need to be defined as well to > be able to used the extended ACK feature. > --- > ell/netlink-private.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ell/netlink-private.h b/ell/netlink-private.h > index 0a1b016d8887..fdb584e62652 100644 > --- a/ell/netlink-private.h > +++ b/ell/netlink-private.h > @@ -27,6 +27,8 @@ enum nlmsgerr_attrs { > NLMSGERR_ATTR_MSG, > NLMSGERR_ATTR_OFFS, > }; > +#define NLM_F_CAPPED 0x100 > +#define NLM_F_ACK_TLVS 0x200 > #endif I applied this patch. Regards Marcel
On Nov 21, 2023, at 10:48 AM, Marcel Holtmann <marcel@holtmann.org> wrote: > The feature for NETLINK_EXT_ACK also adds two additional flags. These > are NLM_F_ACK_TLVS and NLM_F_CAPPED and need to be defined as well to > be able to used the extended ACK feature. > — Marcel, I can confirm that ell-0.61 builds with this final patch against my linux-4.9.212 / glibc-2.32 configuration. Thank you! Best, Grant
diff --git a/ell/netlink-private.h b/ell/netlink-private.h index 0a1b016d8887..fdb584e62652 100644 --- a/ell/netlink-private.h +++ b/ell/netlink-private.h @@ -27,6 +27,8 @@ enum nlmsgerr_attrs { NLMSGERR_ATTR_MSG, NLMSGERR_ATTR_OFFS, }; +#define NLM_F_CAPPED 0x100 +#define NLM_F_ACK_TLVS 0x200 #endif bool netlink_parse_ext_ack_error(const struct nlmsghdr *nlmsg,