From patchwork Fri Apr 5 12:13:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugen Hristev X-Patchwork-Id: 13618988 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F799C67861 for ; Fri, 5 Apr 2024 12:14:15 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rsiSS-0003xw-Dg; Fri, 05 Apr 2024 12:14:12 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rsiSR-0003xq-BL for linux-f2fs-devel@lists.sourceforge.net; Fri, 05 Apr 2024 12:14:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JosxUzynd34XCkid+hAp47byg5qEfldOXfxpLt6DO0g=; b=KKI2/hn4NcEr5xMeOlzvVxeW3V tvzB77yxariavAzCQ2LksskJwip+rrF3MeCt9kfhE6lZoHLR4/ZYhf8vCfbskQrJ7wHCO4jQkBiET VgQL0zIFBxxAXtZll2Er6kxCMvn9SeH1f7klFIIAW+C3QeiqlzBppQCtyUSb6TQ/eWy0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=JosxUzynd34XCkid+hAp47byg5qEfldOXfxpLt6DO0g=; b=j dYOmHAgBanT9hpF0iDwQu57yRvMua+2moXPcRdYnQLdYgw+taYuryc+i0Bro5eTWrcbQUGNqwhr1F JuLowh7gy/MUKNq7LsNMUss8fUdPLg8sa/CqRi8wR/r4whvsU0OCtNAl9bTx35iz4NcO1h6CfGzuN uSq1g8ybMXNQlrYo=; Received: from madrid.collaboradmins.com ([46.235.227.194]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1rsiSN-0004X2-48 for linux-f2fs-devel@lists.sourceforge.net; Fri, 05 Apr 2024 12:14:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1712319241; bh=2daGheRm0uXiCuDJJyljgieXxs67abLqxPGSfK/8mhY=; h=From:To:Cc:Subject:Date:From; b=iGQlbNEXxP5v0qaD7xtPldYxUHkT7lbfQj62HSkTccTr/2WeJpRCxCD9/BthkOzRG TgUbetxkDo9pLtb1hPSYsn83K/1KKkKKQRBpReW5EKnNyFIoLkEScDzlkTRA1UJ9Mr DWVKUHEB/zobSNALpWsyvoxlQlJvsUun0VxtF1VAOcbj8IMMFhhrI9l2aX6Zjy6xuK jH7YA9ygISpfpa8rWriqCfj2Y4jcLxMqRxy8YKdB7yYqc/MYo9vsdpOdR/A1OSHRip SjvKLvx/R57WKy8poxdO8+TeszWDZcMUcF4YNi1PUeivj/XQfeCvlXTnWjl0F7/gks KQoNRs0F1K3QQ== Received: from eugen-station.. (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ehristev) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 2DF77378212E; Fri, 5 Apr 2024 12:14:00 +0000 (UTC) To: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, jaegeuk@kernel.org, chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Date: Fri, 5 Apr 2024 15:13:23 +0300 Message-Id: <20240405121332.689228-1-eugen.hristev@collabora.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Headers-End: 1rsiSN-0004X2-48 Subject: [f2fs-dev] [PATCH v16 0/9] Cache insensitive cleanup for ext4/f2fs X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Eugen Hristev via Linux-f2fs-devel From: Eugen Hristev Reply-To: Eugen Hristev Cc: krisman@suse.de, brauner@kernel.org, jack@suse.cz, linux-kernel@vger.kernel.org, eugen.hristev@collabora.com, ebiggers@kernel.org, viro@zeniv.linux.org.uk, kernel@collabora.com Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Hello, I am trying to respin the series here : https://www.spinics.net/lists/linux-ext4/msg85081.html I resent some of the v9 patches and got some reviews from Gabriel, I did changes as requested and here is v16. Changes in v16: - rewrote patch 2/9 without `match` - changed to return value in generic_ci_match coming from utf8 compare only in strict mode. - changed f2fs_warn to *_ratelimited in 7/9 - removed the declaration of f2fs_cf_name_slab in recovery.c as it's no longer needed. Changes in v15: - fix wrong check `ret<0` in 7/9 - fix memleak reintroduced in 8/9 Changes in v14: - fix wrong kfree unchecked call - changed the return code in 3/8 Changes in v13: - removed stray wrong line in 2/8 - removed old R-b as it's too long since they were given - removed check for null buff in 2/8 - added new patch `f2fs: Log error when lookup of encoded dentry fails` as suggested - rebased on unicode.git for-next branch Changes in v12: - revert to v10 comparison with propagating the error code from utf comparison Changes in v11: - revert to the original v9 implementation for the comparison helper. Changes in v10: - reworked a bit the comparison helper to improve performance by first performing the exact lookup. * Original commit letter The case-insensitive implementations in f2fs and ext4 have quite a bit of duplicated code. This series simplifies the ext4 version, with the goal of extracting ext4_ci_compare into a helper library that can be used by both filesystems. It also reduces the clutter from many codeguards for CONFIG_UNICODE; as requested by Linus, they are part of the codeflow now. While there, I noticed we can leverage the utf8 functions to detect encoded names that are corrupted in the filesystem. Therefore, it also adds an ext4 error on that scenario, to mark the filesystem as corrupted. This series survived passes of xfstests -g quick. Eugen Hristev (1): f2fs: Log error when lookup of encoded dentry fails Gabriel Krisman Bertazi (8): ext4: Simplify the handling of cached insensitive names f2fs: Simplify the handling of cached insensitive names libfs: Introduce case-insensitive string comparison helper ext4: Reuse generic_ci_match for ci comparisons f2fs: Reuse generic_ci_match for ci comparisons ext4: Log error when lookup of encoded dentry fails ext4: Move CONFIG_UNICODE defguards into the code flow f2fs: Move CONFIG_UNICODE defguards into the code flow fs/ext4/crypto.c | 10 +--- fs/ext4/ext4.h | 35 +++++++----- fs/ext4/namei.c | 129 ++++++++++++++++----------------------------- fs/ext4/super.c | 4 +- fs/f2fs/dir.c | 108 ++++++++++++------------------------- fs/f2fs/f2fs.h | 16 +++++- fs/f2fs/namei.c | 10 ++-- fs/f2fs/recovery.c | 9 +--- fs/f2fs/super.c | 8 +-- fs/libfs.c | 73 +++++++++++++++++++++++++ include/linux/fs.h | 4 ++ 11 files changed, 206 insertions(+), 200 deletions(-)