diff mbox series

[f2fs-dev,V2] f2fs: fix some ambiguous comments

Message ID 1714132889-9423-1-git-send-email-zhiguo.niu@unisoc.com (mailing list archive)
State Accepted
Commit 991b6bdf1b009832256f8bc3035d4bcba664657b
Headers show
Series [f2fs-dev,V2] f2fs: fix some ambiguous comments | expand

Commit Message

Zhiguo Niu April 26, 2024, 12:01 p.m. UTC 
After commit d7e9a9037de2 ("f2fs: Support Block Size == Page Size"),
Some comments are confused and just correct with block size is 4KB.

Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
---
v2: add comments "support 64 TB disk size for 16K page size"
---
---
 include/linux/f2fs_fs.h | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Comments

patchwork-bot+f2fs@kernel.org May 11, 2024, 12:50 a.m. UTC | #1 
Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <jaegeuk@kernel.org>:

On Fri, 26 Apr 2024 20:01:29 +0800 you wrote:
> After commit d7e9a9037de2 ("f2fs: Support Block Size == Page Size"),
> Some comments are confused and just correct with block size is 4KB.
> 
> Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
> ---
> v2: add comments "support 64 TB disk size for 16K page size"
> 
> [...]

Here is the summary with links:
  - [f2fs-dev,V2] f2fs: fix some ambiguous comments
    https://git.kernel.org/jaegeuk/f2fs/c/991b6bdf1b00

You are awesome, thank you!
diff mbox series

Patch

diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h
index a357287..41d1d71 100644
--- a/include/linux/f2fs_fs.h
+++ b/include/linux/f2fs_fs.h
@@ -394,7 +394,8 @@  struct f2fs_nat_block {
 
 /*
  * F2FS uses 4 bytes to represent block address. As a result, supported size of
- * disk is 16 TB and it equals to 16 * 1024 * 1024 / 2 segments.
+ * disk is 16 TB for a 4K page size and 64 TB for a 16K page size and it equals
+ * to 16 * 1024 * 1024 / 2 segments.
  */
 #define F2FS_MAX_SEGMENT       ((16 * 1024 * 1024) / 2)
 
@@ -424,8 +425,10 @@  struct f2fs_sit_block {
 /*
  * For segment summary
  *
- * One summary block contains exactly 512 summary entries, which represents
- * exactly one segment by default. Not allow to change the basic units.
+ * One summary block with 4KB size contains exactly 512 summary entries, which
+ * represents exactly one segment with 2MB size.
+ * Similarly, in the case of block with 16KB size, it represents one segment with 8MB size.
+ * Not allow to change the basic units.
  *
  * NOTE: For initializing fields, you must use set_summary
  *
@@ -556,6 +559,7 @@  struct f2fs_summary_block {
 
 /*
  * space utilization of regular dentry and inline dentry (w/o extra reservation)
+ * when block size is 4KB.
  *		regular dentry		inline dentry (def)	inline dentry (min)
  * bitmap	1 * 27 = 27		1 * 23 = 23		1 * 1 = 1
  * reserved	1 * 3 = 3		1 * 7 = 7		1 * 1 = 1