diff mbox series

[f2fs-dev,v2] f2fs: fix to check warm_data_age_threshold

Message ID 20230117132442.77645-1-frank.li@vivo.com (mailing list archive)
State Accepted
Commit 3d41b70411d0e581490a46ae8eb766670c49b902
Headers show
Series [f2fs-dev,v2] f2fs: fix to check warm_data_age_threshold | expand

Commit Message

Yangtao Li Jan. 17, 2023, 1:24 p.m. UTC 
hot_data_age_threshold is a non-zero positive number, and
condition 2 includes condition 1, so there is no need to
additionally judge whether t is 0. And let's remove it.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 fs/f2fs/sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+f2fs@kernel.org Jan. 30, 2023, 11 p.m. UTC | #1 
Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <jaegeuk@kernel.org>:

On Tue, 17 Jan 2023 21:24:42 +0800 you wrote:
> hot_data_age_threshold is a non-zero positive number, and
> condition 2 includes condition 1, so there is no need to
> additionally judge whether t is 0. And let's remove it.
> 
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
>  fs/f2fs/sysfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [f2fs-dev,v2] f2fs: fix to check warm_data_age_threshold
    https://git.kernel.org/jaegeuk/f2fs/c/3d41b70411d0

You are awesome, thank you!
diff mbox series

Patch

diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
index e396851a6dd1..3c6425f9ed0a 100644
--- a/fs/f2fs/sysfs.c
+++ b/fs/f2fs/sysfs.c
@@ -689,7 +689,7 @@  static ssize_t __sbi_store(struct f2fs_attr *a,
 	}
 
 	if (!strcmp(a->attr.name, "warm_data_age_threshold")) {
-		if (t == 0 || t <= sbi->hot_data_age_threshold)
+		if (t <= sbi->hot_data_age_threshold)
 			return -EINVAL;
 		if (t == *ui)
 			return count;