| Message ID | 20230215024850epcms2p22be2cc864d82b44f31c19a7ef28770b6@epcms2p2 (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [f2fs-dev,v1] f2fs: fix uninitialized skipped_gc_rwsem | expand |
On 2023/2/15 10:48, Yonggil Song wrote: > When f2fs skipped a gc round during victim migration, there was a bug which > would skip all upcoming gc rounds unconditionally because skipped_gc_rwsem > was not initialized. It fixes the bug by correctly initializing the > skipped_gc_rwsem inside the gc loop. It makes sense to me. > > Fixes: d147ea4adb96 ("f2fs: introduce f2fs_gc_control to consolidate f2fs_gc parameters") How does this commits introduce the bug? Thanks, > Signed-off-by: Yonggil Song <yonggil.song@samsung.com> > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index b22f49a6f128..81d326abaac1 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -1786,8 +1786,8 @@ int f2fs_gc(struct f2fs_sb_info *sbi, struct f2fs_gc_control *gc_control) > prefree_segments(sbi)); > > cpc.reason = __get_cp_reason(sbi); > - sbi->skipped_gc_rwsem = 0; > gc_more: > + sbi->skipped_gc_rwsem = 0; > if (unlikely(!(sbi->sb->s_flags & SB_ACTIVE))) { > ret = -EINVAL; > goto stop;
On 2023/2/15 10:48, Yonggil Song wrote: >> When f2fs skipped a gc round during victim migration, there was a bug which >> would skip all upcoming gc rounds unconditionally because skipped_gc_rwsem >> was not initialized. It fixes the bug by correctly initializing the >> skipped_gc_rwsem inside the gc loop. > >It makes sense to me. > >> >> Fixes: d147ea4adb96 ("f2fs: introduce f2fs_gc_control to consolidate f2fs_gc parameters") > >How does this commits introduce the bug? Oh, sorry I've got wrong hash. I'll send right hash on PATCH v2. Thanks for your comment. > >Thanks, > >> Signed-off-by: Yonggil Song <yonggil.song@samsung.com> >> >> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c >> index b22f49a6f128..81d326abaac1 100644 >> --- a/fs/f2fs/gc.c >> +++ b/fs/f2fs/gc.c >> @@ -1786,8 +1786,8 @@ int f2fs_gc(struct f2fs_sb_info *sbi, struct f2fs_gc_control *gc_control) >> prefree_segments(sbi)); >> >> cpc.reason = __get_cp_reason(sbi); >> - sbi->skipped_gc_rwsem = 0; >> gc_more: >> + sbi->skipped_gc_rwsem = 0; >> if (unlikely(!(sbi->sb->s_flags & SB_ACTIVE))) { >> ret = -EINVAL; >> goto stop;
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index b22f49a6f128..81d326abaac1 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -1786,8 +1786,8 @@ int f2fs_gc(struct f2fs_sb_info *sbi, struct f2fs_gc_control *gc_control) prefree_segments(sbi)); cpc.reason = __get_cp_reason(sbi); - sbi->skipped_gc_rwsem = 0; gc_more: + sbi->skipped_gc_rwsem = 0; if (unlikely(!(sbi->sb->s_flags & SB_ACTIVE))) { ret = -EINVAL; goto stop;
When f2fs skipped a gc round during victim migration, there was a bug which would skip all upcoming gc rounds unconditionally because skipped_gc_rwsem was not initialized. It fixes the bug by correctly initializing the skipped_gc_rwsem inside the gc loop. Fixes: d147ea4adb96 ("f2fs: introduce f2fs_gc_control to consolidate f2fs_gc parameters") Signed-off-by: Yonggil Song <yonggil.song@samsung.com>