| Message ID | 20230606061901.1179970-1-chao@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e6fd55c1f4b6b540a4fc2628f17c4a1e86df7d56 |
| Headers | show |
| Series | [f2fs-dev] f2fs: check return value of freeze_super() | expand |
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Tue, 6 Jun 2023 14:19:01 +0800 you wrote: > freeze_super() can fail, it needs to check its return value and do > error handling in f2fs_resize_fs(). > > Fixes: 04f0b2eaa3b3 ("f2fs: ioctl for removing a range from F2FS") > Fixes: b4b10061ef98 ("f2fs: refactor resize_fs to avoid meta updates in progress") > Signed-off-by: Chao Yu <chao@kernel.org> > > [...] Here is the summary with links: - [f2fs-dev] f2fs: check return value of freeze_super() https://git.kernel.org/jaegeuk/f2fs/c/e6fd55c1f4b6 You are awesome, thank you!
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 8cbe4839f640..de893f4f60e1 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -2271,7 +2271,9 @@ int f2fs_resize_fs(struct file *filp, __u64 block_count) if (err) return err; - freeze_super(sbi->sb); + err = freeze_super(sbi->sb); + if (err) + return err; if (f2fs_readonly(sbi->sb)) { thaw_super(sbi->sb);
freeze_super() can fail, it needs to check its return value and do error handling in f2fs_resize_fs(). Fixes: 04f0b2eaa3b3 ("f2fs: ioctl for removing a range from F2FS") Fixes: b4b10061ef98 ("f2fs: refactor resize_fs to avoid meta updates in progress") Signed-off-by: Chao Yu <chao@kernel.org> --- fs/f2fs/gc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)