| Message ID | 20230616142009.2332411-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 71a1277a46dad36d79b43ea089151456ff442b12 |
| Headers | show |
| Series | [f2fs-dev,next] f2fs: remove redundant assignment to variable err | expand |
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Fri, 16 Jun 2023 15:20:09 +0100 you wrote: > The assignment to variable err is redundant since the code jumps to > label next and err is then re-assigned a new value on the call to > sanity_check_node_chain. Remove the assignment. > > Cleans up clang scan build warning: > fs/f2fs/recovery.c:464:6: warning: Value stored to 'err' is never read [deadcode.DeadStores] > > [...] Here is the summary with links: - [f2fs-dev,next] f2fs: remove redundant assignment to variable err https://git.kernel.org/jaegeuk/f2fs/c/71a1277a46da You are awesome, thank you!
diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c index f0cf1538389c..4e7d4ceeb084 100644 --- a/fs/f2fs/recovery.c +++ b/fs/f2fs/recovery.c @@ -460,10 +460,8 @@ static int find_fsync_dnodes(struct f2fs_sb_info *sbi, struct list_head *head, quota_inode); if (IS_ERR(entry)) { err = PTR_ERR(entry); - if (err == -ENOENT) { - err = 0; + if (err == -ENOENT) goto next; - } f2fs_put_page(page, 1); break; }
The assignment to variable err is redundant since the code jumps to label next and err is then re-assigned a new value on the call to sanity_check_node_chain. Remove the assignment. Cleans up clang scan build warning: fs/f2fs/recovery.c:464:6: warning: Value stored to 'err' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- fs/f2fs/recovery.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)