| Message ID | 20231201230257.238513-1-jaegeuk@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 29215a7d43c77466f2d7e6c264942e6bc8e06cd8 |
| Headers | show |
| Series | [f2fs-dev] f2fs: allow checkpoint=disable for zoned block device | expand |
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Fri, 1 Dec 2023 15:02:56 -0800 you wrote: > Let's allow checkpoint=disable back for zoned block device. It's very risky > as the feature relies on fsck or runtime recovery which matches the write > pointers again if the device rebooted while disabling the checkpoint. > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > --- > fs/f2fs/super.c | 5 ----- > 1 file changed, 5 deletions(-) Here is the summary with links: - [f2fs-dev] f2fs: allow checkpoint=disable for zoned block device https://git.kernel.org/jaegeuk/f2fs/c/29215a7d43c7 You are awesome, thank you!
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 033af907c3b1..617340e9ea7f 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -1422,11 +1422,6 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount) } } - if (test_opt(sbi, DISABLE_CHECKPOINT) && f2fs_lfs_mode(sbi)) { - f2fs_err(sbi, "LFS is not compatible with checkpoint=disable"); - return -EINVAL; - } - if (test_opt(sbi, ATGC) && f2fs_lfs_mode(sbi)) { f2fs_err(sbi, "LFS is not compatible with ATGC"); return -EINVAL;
Let's allow checkpoint=disable back for zoned block device. It's very risky as the feature relies on fsck or runtime recovery which matches the write pointers again if the device rebooted while disabling the checkpoint. Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> --- fs/f2fs/super.c | 5 ----- 1 file changed, 5 deletions(-)