| Message ID | 20240523132948.2250254-1-chao@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5c8764f8679e659c5cb295af7d32279002d13735 |
| Headers | show |
| Series | [f2fs-dev] f2fs: fix to force buffered IO on inline_data inode | expand |
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Thu, 23 May 2024 21:29:48 +0800 you wrote: > It will return all zero data when DIO reading from inline_data inode, it > is because f2fs_iomap_begin() assign iomap->type w/ IOMAP_HOLE incorrectly > for this case. > > We can let iomap framework handle inline data via assigning iomap->type > and iomap->inline_data correctly, however, it will be a little bit > complicated when handling race case in between direct IO and buffered IO. > > [...] Here is the summary with links: - [f2fs-dev] f2fs: fix to force buffered IO on inline_data inode https://git.kernel.org/jaegeuk/f2fs/c/5c8764f8679e You are awesome, thank you!
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index db6236f27852..e038910ad1e5 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -851,6 +851,8 @@ static bool f2fs_force_buffered_io(struct inode *inode, int rw) return true; if (f2fs_compressed_file(inode)) return true; + if (f2fs_has_inline_data(inode)) + return true; /* disallow direct IO if any of devices has unaligned blksize */ if (f2fs_is_multi_device(sbi) && !sbi->aligned_blksize)
It will return all zero data when DIO reading from inline_data inode, it is because f2fs_iomap_begin() assign iomap->type w/ IOMAP_HOLE incorrectly for this case. We can let iomap framework handle inline data via assigning iomap->type and iomap->inline_data correctly, however, it will be a little bit complicated when handling race case in between direct IO and buffered IO. So, let's force to use buffered IO to fix this issue. Cc: stable@vger.kernel.org Reported-by: Barry Song <v-songbaohua@oppo.com> Signed-off-by: Chao Yu <chao@kernel.org> --- fs/f2fs/file.c | 2 ++ 1 file changed, 2 insertions(+)