| Message ID | 20241021044801.1358850-1-yangyongpeng1@oppo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f2bbbe277c22925ad29b19c190892d19dad610a7 |
| Headers | show |
| Series | [f2fs-dev] f2fs: check curseg->inited before write_sum_page in change_curseg | expand |
On 2024/10/21 12:48, Yongpeng Yang wrote: > In the __f2fs_init_atgc_curseg->get_atssr_segment calling, > curseg->segno is NULL_SEGNO, indicating that there is no summary > block that needs to be written. > Fixes: 093749e296e2 ("f2fs: support age threshold based garbage collection") > Signed-off-by: Yongpeng Yang <yangyongpeng1@oppo.com> Reviewed-by: Chao Yu <chao@kernel.org> Thanks,
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Mon, 21 Oct 2024 12:48:01 +0800 you wrote: > In the __f2fs_init_atgc_curseg->get_atssr_segment calling, > curseg->segno is NULL_SEGNO, indicating that there is no summary > block that needs to be written. > > Signed-off-by: Yongpeng Yang <yangyongpeng1@oppo.com> > --- > fs/f2fs/segment.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Here is the summary with links: - [f2fs-dev] f2fs: check curseg->inited before write_sum_page in change_curseg https://git.kernel.org/jaegeuk/f2fs/c/f2bbbe277c22 You are awesome, thank you!
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 1766254279d2..35f0b5065554 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -2926,7 +2926,8 @@ static int change_curseg(struct f2fs_sb_info *sbi, int type) struct f2fs_summary_block *sum_node; struct page *sum_page; - write_sum_page(sbi, curseg->sum_blk, GET_SUM_BLOCK(sbi, curseg->segno)); + if (curseg->inited) + write_sum_page(sbi, curseg->sum_blk, GET_SUM_BLOCK(sbi, curseg->segno)); __set_test_and_inuse(sbi, new_segno);
In the __f2fs_init_atgc_curseg->get_atssr_segment calling, curseg->segno is NULL_SEGNO, indicating that there is no summary block that needs to be written. Signed-off-by: Yongpeng Yang <yangyongpeng1@oppo.com> --- fs/f2fs/segment.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)