| Message ID | 20241028112058.3346-2-thorsten.blum@linux.dev (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 527a4ded09b9266a5fb100e80e05b101b53053fd |
| Headers | show |
| Series | [f2fs-dev,RESEND] f2fs: Use struct_size() to improve f2fs_acl_clone() | expand |
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Mon, 28 Oct 2024 12:20:58 +0100 you wrote: > Use struct_size() to calculate the number of bytes to allocate for a > cloned acl. > > Reviewed-by: Chao Yu <chao@kernel.org> > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> > --- > fs/f2fs/acl.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Here is the summary with links: - [f2fs-dev,RESEND] f2fs: Use struct_size() to improve f2fs_acl_clone() https://git.kernel.org/jaegeuk/f2fs/c/527a4ded09b9 You are awesome, thank you!
diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c index 8bffdeccdbc3..1fbc0607363b 100644 --- a/fs/f2fs/acl.c +++ b/fs/f2fs/acl.c @@ -296,9 +296,8 @@ static struct posix_acl *f2fs_acl_clone(const struct posix_acl *acl, struct posix_acl *clone = NULL; if (acl) { - int size = sizeof(struct posix_acl) + acl->a_count * - sizeof(struct posix_acl_entry); - clone = kmemdup(acl, size, flags); + clone = kmemdup(acl, struct_size(acl, a_entries, acl->a_count), + flags); if (clone) refcount_set(&clone->a_refcount, 1); }