From patchwork Mon Nov 11 03:04:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaegeuk Kim X-Patchwork-Id: 13870198 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8268D12D64 for ; Mon, 11 Nov 2024 03:05:10 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tAKjk-0003Nq-NP; Mon, 11 Nov 2024 03:05:08 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tAKji-0003Nb-R0 for linux-f2fs-devel@lists.sourceforge.net; Mon, 11 Nov 2024 03:05:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=u7UX/izpOmCFAWFDMF8tJFgep5mM0uBjrtDEVZtPIRY=; b=hZRSxkVZwDe95W5IKR9Uql8iG7 0acVxMJK9mUNcb3glLkibedERM13s296A+cWKHO6U73hkhRtc+r9GsEvm/e0Xe+DEEM+EW+0NYrqF ltYu0ZL+pYMrnXDnMxwNFuCTyfzEzQHtXGyRRCyiLYclKInfRdHRLEqO9yiVXT+5AMww=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=u7UX/izpOmCFAWFDMF8tJFgep5mM0uBjrtDEVZtPIRY=; b=Y eqpCioV4u6DYyU7jo1JhUhFFVf0dlTaRB0Y8mZ00fVWEj0alySvb3Cw4Rukqh5FmyYa7Yyua3lfXC S9EdUK0LQW9Ai1AJdLZ9hMbDCpGi1zMZ0AySVhN3t6f+nREhQ/nT641FspyHdSdEKf4JZwuVxO0za VARRwrJYN3fL+r48=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1tAKji-0004Se-6Z for linux-f2fs-devel@lists.sourceforge.net; Mon, 11 Nov 2024 03:05:06 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 666055C56D6 for ; Mon, 11 Nov 2024 03:04:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79495C4CECD; Mon, 11 Nov 2024 03:05:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731294300; bh=AWpyNMW1dieaheGEiGBKpMuE3jX/0v5RuFtwBBIpGKY=; h=From:To:Cc:Subject:Date:From; b=S6nzSunsDRvi04UmX5HBYR8HXp72cguc2pjKV9XDqfoaCqK56JRVvEVKnwEKAfKlo Mw4/ms7Vhs/Lr2xEBAK+WzBGDVFTDH3lAZgzxw8LFBCSTpdZJMpg1A7Kfs1m9xIoRI PSCwZ7sMKAf+bG/j+JBtbGygzFoOQeEc0E0sfUVNW7F+IrwwOnzCenYax+Rp4CLfvd Q4f6aosDsJjqE1ywnlAGPtdzlSMLplvP5Aqnqfnf3I6TelN9kRp2e2AE2JHIMnAV60 gMA3KFIswKv8qayiL6ohnSF976JjzIc19AvClvLsKo5bkyqojtCmCssuuZwbAfA9D7 YZJkMGThRm6XA== To: linux-f2fs-devel@lists.sourceforge.net Date: Mon, 11 Nov 2024 03:04:56 +0000 Message-ID: <20241111030456.2572093-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.47.0.277.g8800431eea-goog MIME-Version: 1.0 X-Headers-End: 1tAKji-0004Se-6Z Subject: [f2fs-dev] [PATCH] mkfs.f2fs: remove IMMUTABLE bit X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jaegeuk Kim via Linux-f2fs-devel From: Jaegeuk Kim Reply-To: Jaegeuk Kim Cc: Jaegeuk Kim Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net The immutable bit disallows selinux permission which gives no way to clear it. Fixes: 8cc4e257ec20 ("mkfs.f2fs: add device aliasing feature") Signed-off-by: Jaegeuk Kim Reviewed-by: Daeho Jeong Reviewed-by: Chao Yu --- mkfs/f2fs_format.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c index 52a1e1864b29..6635eed99813 100644 --- a/mkfs/f2fs_format.c +++ b/mkfs/f2fs_format.c @@ -1748,8 +1748,7 @@ static int f2fs_write_alias_inodes(void) dev_off++; f2fs_init_inode(sb, raw_node, ino, mkfs_time, 0x81c0); - raw_node->i.i_flags = cpu_to_le32(F2FS_IMMUTABLE_FL | - F2FS_DEVICE_ALIAS_FL); + raw_node->i.i_flags = cpu_to_le32(F2FS_DEVICE_ALIAS_FL); raw_node->i.i_inline = F2FS_PIN_FILE; raw_node->i.i_pino = sb->root_ino; filename = c.devices[i].alias_filename;