From patchwork Fri Dec 20 23:41:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lee X-Patchwork-Id: 13917535 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B061E77188 for ; Fri, 20 Dec 2024 23:42:06 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tOmd9-0000Cb-ET; Fri, 20 Dec 2024 23:42:04 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from <3wwBmZwcKAJ4AFSJJCCEMMEJC.AMK@flex--chullee.bounces.google.com>) id 1tOmd7-0000CU-I9 for linux-f2fs-devel@lists.sourceforge.net; Fri, 20 Dec 2024 23:42:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Cc:To:From:Subject:Message-ID: Mime-Version:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=e75MwXe3tYr2+BT2jIJHRYb14Iw4G5F1URC8lI1VJCQ=; b=MFg3lRR8kL+hyG92dKRjr0SwK4 Y23l8Bbhs/g8YhNCc6MEKhTHE/g9KqiRFPcy2Bbg/GLdtaxc1xxF1ZsrAL4GgFyxqDJ2HY9N0YkzD fiRCGUtMhKm0axPySfA3h4GguukmnAdFGP63kG0/es6rQB1kn2LK8jog2yL+8SWrxulY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Cc:To:From:Subject:Message-ID:Mime-Version:Date:Sender: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=e75MwXe3tYr2+BT2jIJHRYb14Iw4G5F1URC8lI1VJCQ=; b=d DD6KeUqepCNqev29DbCbY1DUre82AA2ChJHpaA746QEZZULTqBbenbR92iKH+2YM0S0Ba6X/ZNmrd I2WO9a4jw088JGbeYTndVRxiKb/dfcW2wIYMlni3DA46h2fIDkrBXYLhE34PeBVVD9+Z/8DuvARex ROVTxLADrFk2tR/4=; Received: from mail-pf1-f201.google.com ([209.85.210.201]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1tOmd7-0003YG-AE for linux-f2fs-devel@lists.sourceforge.net; Fri, 20 Dec 2024 23:42:02 +0000 Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-725dab9fe44so2157673b3a.1 for ; Fri, 20 Dec 2024 15:42:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1734738116; x=1735342916; darn=lists.sourceforge.net; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=e75MwXe3tYr2+BT2jIJHRYb14Iw4G5F1URC8lI1VJCQ=; b=Bt5p4aIu0XuxYJYpAMRaqSNB8v+vGvgvERQvIhPP5Ls24SVH9nI1M1hLXLcfyD7MoE qaIWM0WGHRRA62NDs79HhSKRgVQnzKl6eSvvgm/H0P5MR4uJOr2y/yEW+bIe/8g9dD2I Dr3LsmOKgt80fEZnOSgocgoHImdUxg8b+FnM2nBsJVAYU5ljEN+jC8crE9Y4WI/41VV0 2jtLBjDX4cNGDq2o27IeCyltGNIX40EPDcLHgpWtnT1S9MuqbepKo/+Mo2LqRyGzRHNe hpd8Z6H667x1Wy2uhkAyucT6tL5D8m7oxeDGguz/oXKsYve1OEOAaUN7OkR5qWp4xOKe /JiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734738116; x=1735342916; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=e75MwXe3tYr2+BT2jIJHRYb14Iw4G5F1URC8lI1VJCQ=; b=jnxleYQhpgBfSKLTjgytQ0cs/wxIwOjiRwQ+2OG1ZJotTpLZdLS9pCRWmg5o8EF7bi fyILd8wxw1uAAQWYK19QExsHYUitUfiFewZKiAKMk58bu2r5iHvop43SnvvpId1zt7L/ 7jXqbqd2ocLkFht3d8jxhRWwR3QMIZ4ED0oDNBvaqbgUqo44SUjGURej7HdRP/EkAisP 8n+JCnNQHeSxPrqmzLZH5pnUCCokTnt82+xsfwritgg5RJwLCKxLCwMiV5LwZlAMBVew DUlpVNQ4OXYUZgno/6+1qasYMuwmCg31k3FLtnXEas+f2nl3lwfiGdmfeZwD+IKarYnQ gufQ== X-Gm-Message-State: AOJu0YwYD9NXx11ai9JoE0n3KJjD3CzpNru3Ywg24a35GKEC83i0vJY3 ffNUp50YYj0kiWXxCbA39E/6WDkfDKgEtaFRZ/xNEwOEgUHtd/7onWwLFzAxiex4u+b2187dGX2 1i8a0Ew== X-Google-Smtp-Source: AGHT+IGT5FzN4SOvU6kb09c0YEJD/D30FnTJxgkBrqrI7MxPzU5vOiJmV+fF1CDLeVxXeAr4reXJNwZm1/Vt X-Received: from pfba9.prod.google.com ([2002:a05:6a00:ac09:b0:728:aad0:33a4]) (user=chullee job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:6103:b0:72a:b292:1e96 with SMTP id d2e1a72fcca58-72ab2921ec7mr11705911b3a.12.1734738115599; Fri, 20 Dec 2024 15:41:55 -0800 (PST) Date: Fri, 20 Dec 2024 15:41:31 -0800 Mime-Version: 1.0 X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Message-ID: <20241220234131.1089833-1-chullee@google.com> To: Jaegeuk Kim , Chao Yu X-Headers-End: 1tOmd7-0003YG-AE Subject: [f2fs-dev] [PATCH v3] f2fs: Introduce linear search for dentries X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Daniel Lee via Linux-f2fs-devel From: Daniel Lee Reply-To: Daniel Lee Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net This patch addresses an issue where some files in case-insensitive directories become inaccessible due to changes in how the kernel function, utf8_casefold(), generates case-folded strings from the commit 5c26d2f1d3f5 ("unicode: Don't special case ignorable code points"). F2FS uses these case-folded names to calculate hash values for locating dentries and stores them on disk. Since utf8_casefold() can produce different output across kernel versions, stored hash values and newly calculated hash values may differ. This results in affected files no longer being found via the hash-based lookup. To resolve this, the patch introduces a linear search fallback. If the initial hash-based search fails, F2FS will sequentially scan the directory entries. Fixes: 5c26d2f1d3f5 ("unicode: Don't special case ignorable code points") Link: https://bugzilla.kernel.org/show_bug.cgi?id=219586 Signed-off-by: Daniel Lee Reviewed-by: Chao Yu --- v3: - Fix the unused label warning v2: - Only update chash if use_hash is true fs/f2fs/dir.c | 42 +++++++++++++++++++++++++++++++----------- fs/f2fs/f2fs.h | 6 ++++-- fs/f2fs/inline.c | 5 +++-- 3 files changed, 38 insertions(+), 15 deletions(-) diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index 47a5c806cf16..058b8be9a373 100644 --- a/fs/f2fs/dir.c +++ b/fs/f2fs/dir.c @@ -175,7 +175,8 @@ static unsigned long dir_block_index(unsigned int level, static struct f2fs_dir_entry *find_in_block(struct inode *dir, struct page *dentry_page, const struct f2fs_filename *fname, - int *max_slots) + int *max_slots, + bool use_hash) { struct f2fs_dentry_block *dentry_blk; struct f2fs_dentry_ptr d; @@ -183,7 +184,7 @@ static struct f2fs_dir_entry *find_in_block(struct inode *dir, dentry_blk = (struct f2fs_dentry_block *)page_address(dentry_page); make_dentry_ptr_block(dir, &d, dentry_blk); - return f2fs_find_target_dentry(&d, fname, max_slots); + return f2fs_find_target_dentry(&d, fname, max_slots, use_hash); } static inline int f2fs_match_name(const struct inode *dir, @@ -208,7 +209,8 @@ static inline int f2fs_match_name(const struct inode *dir, } struct f2fs_dir_entry *f2fs_find_target_dentry(const struct f2fs_dentry_ptr *d, - const struct f2fs_filename *fname, int *max_slots) + const struct f2fs_filename *fname, int *max_slots, + bool use_hash) { struct f2fs_dir_entry *de; unsigned long bit_pos = 0; @@ -231,7 +233,7 @@ struct f2fs_dir_entry *f2fs_find_target_dentry(const struct f2fs_dentry_ptr *d, continue; } - if (de->hash_code == fname->hash) { + if (!use_hash || de->hash_code == fname->hash) { res = f2fs_match_name(d->inode, fname, d->filename[bit_pos], le16_to_cpu(de->name_len)); @@ -258,11 +260,12 @@ struct f2fs_dir_entry *f2fs_find_target_dentry(const struct f2fs_dentry_ptr *d, static struct f2fs_dir_entry *find_in_level(struct inode *dir, unsigned int level, const struct f2fs_filename *fname, - struct page **res_page) + struct page **res_page, + bool use_hash) { int s = GET_DENTRY_SLOTS(fname->disk_name.len); unsigned int nbucket, nblock; - unsigned int bidx, end_block; + unsigned int bidx, end_block, bucket_no; struct page *dentry_page; struct f2fs_dir_entry *de = NULL; pgoff_t next_pgofs; @@ -272,8 +275,11 @@ static struct f2fs_dir_entry *find_in_level(struct inode *dir, nbucket = dir_buckets(level, F2FS_I(dir)->i_dir_level); nblock = bucket_blocks(level); + bucket_no = use_hash ? le32_to_cpu(fname->hash) % nbucket : 0; + +start_find_bucket: bidx = dir_block_index(level, F2FS_I(dir)->i_dir_level, - le32_to_cpu(fname->hash) % nbucket); + bucket_no); end_block = bidx + nblock; while (bidx < end_block) { @@ -290,7 +296,7 @@ static struct f2fs_dir_entry *find_in_level(struct inode *dir, } } - de = find_in_block(dir, dentry_page, fname, &max_slots); + de = find_in_block(dir, dentry_page, fname, &max_slots, use_hash); if (IS_ERR(de)) { *res_page = ERR_CAST(de); de = NULL; @@ -307,7 +313,10 @@ static struct f2fs_dir_entry *find_in_level(struct inode *dir, bidx++; } - if (!de && room && F2FS_I(dir)->chash != fname->hash) { + if (!use_hash && !de && ++bucket_no < nbucket) + goto start_find_bucket; + + if (use_hash && !de && room && F2FS_I(dir)->chash != fname->hash) { F2FS_I(dir)->chash = fname->hash; F2FS_I(dir)->clevel = level; } @@ -323,11 +332,15 @@ struct f2fs_dir_entry *__f2fs_find_entry(struct inode *dir, struct f2fs_dir_entry *de = NULL; unsigned int max_depth; unsigned int level; + bool use_hash = true; *res_page = NULL; +#if IS_ENABLED(CONFIG_UNICODE) +start_find_entry: +#endif if (f2fs_has_inline_dentry(dir)) { - de = f2fs_find_in_inline_dir(dir, fname, res_page); + de = f2fs_find_in_inline_dir(dir, fname, res_page, use_hash); goto out; } @@ -343,11 +356,18 @@ struct f2fs_dir_entry *__f2fs_find_entry(struct inode *dir, } for (level = 0; level < max_depth; level++) { - de = find_in_level(dir, level, fname, res_page); + de = find_in_level(dir, level, fname, res_page, use_hash); if (de || IS_ERR(*res_page)) break; } + out: +#if IS_ENABLED(CONFIG_UNICODE) + if (IS_CASEFOLDED(dir) && !de && use_hash) { + use_hash = false; + goto start_find_entry; + } +#endif /* This is to increase the speed of f2fs_create */ if (!de) F2FS_I(dir)->task = current; diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index f523dd302bf6..1afebb9c4061 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -3588,7 +3588,8 @@ int f2fs_prepare_lookup(struct inode *dir, struct dentry *dentry, struct f2fs_filename *fname); void f2fs_free_filename(struct f2fs_filename *fname); struct f2fs_dir_entry *f2fs_find_target_dentry(const struct f2fs_dentry_ptr *d, - const struct f2fs_filename *fname, int *max_slots); + const struct f2fs_filename *fname, int *max_slots, + bool use_hash); int f2fs_fill_dentries(struct dir_context *ctx, struct f2fs_dentry_ptr *d, unsigned int start_pos, struct fscrypt_str *fstr); void f2fs_do_make_empty_dir(struct inode *inode, struct inode *parent, @@ -4224,7 +4225,8 @@ int f2fs_write_inline_data(struct inode *inode, struct folio *folio); int f2fs_recover_inline_data(struct inode *inode, struct page *npage); struct f2fs_dir_entry *f2fs_find_in_inline_dir(struct inode *dir, const struct f2fs_filename *fname, - struct page **res_page); + struct page **res_page, + bool use_hash); int f2fs_make_empty_inline_dir(struct inode *inode, struct inode *parent, struct page *ipage); int f2fs_add_inline_entry(struct inode *dir, const struct f2fs_filename *fname, diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c index cbd2a0d34804..3e3c35d4c98b 100644 --- a/fs/f2fs/inline.c +++ b/fs/f2fs/inline.c @@ -352,7 +352,8 @@ int f2fs_recover_inline_data(struct inode *inode, struct page *npage) struct f2fs_dir_entry *f2fs_find_in_inline_dir(struct inode *dir, const struct f2fs_filename *fname, - struct page **res_page) + struct page **res_page, + bool use_hash) { struct f2fs_sb_info *sbi = F2FS_SB(dir->i_sb); struct f2fs_dir_entry *de; @@ -369,7 +370,7 @@ struct f2fs_dir_entry *f2fs_find_in_inline_dir(struct inode *dir, inline_dentry = inline_data_addr(dir, ipage); make_dentry_ptr_inline(dir, &d, inline_dentry); - de = f2fs_find_target_dentry(&d, fname, NULL); + de = f2fs_find_target_dentry(&d, fname, NULL, use_hash); unlock_page(ipage); if (IS_ERR(de)) { *res_page = ERR_CAST(de);