From patchwork Sun Feb 2 04:32:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kohei Enju X-Patchwork-Id: 13956421 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9A3AC02190 for ; Sun, 2 Feb 2025 04:49:14 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1teRuy-0005BR-VW; Sun, 02 Feb 2025 04:49:12 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1teRux-0005BJ-FH for linux-f2fs-devel@lists.sourceforge.net; Sun, 02 Feb 2025 04:49:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Date:Subject:CC:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5wKm0aYw5LMzGFRHPLrYDtn9SZNot9Fk2U7Cck0hqJ0=; b=FsKmv1MlbHJBLKkRVyt5OlMI2E cj2eoNjYLDX1j/Zp5OZcxxrHImYPFRCDe2lW7UOdhhmp2BG+jMwlzpOLqFWbUQ53ViFnp38mGwvBk aMbSipcGJISjupucRe5YumYmJKqXaUc9O/FZ3NT3EKFtfVf2WDaNextxbi03TlzmY9LM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Date: Subject:CC:To:From:Sender:Reply-To:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=5wKm0aYw5LMzGFRHPLrYDtn9SZNot9Fk2U7Cck0hqJ0=; b=M PrIw6yzF6Sd+hIdJhlqmMpxnwBtRVo/2oxNprKnoMb6YX5D0/QTgy/vLh/oXNmE9KL8kvvpyWMx8C hzBLjAZ1NvPnbrPtWn4DXMPRVYhkoCqEiYTj7qRNuysz/y9YNjp2xu0aXcqBaPLVnSUSKgCF0Oap5 WMup52DhGs4MG4TM=; Received: from smtp-fw-9106.amazon.com ([207.171.188.206]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1teRuw-00077F-5v for linux-f2fs-devel@lists.sourceforge.net; Sun, 02 Feb 2025 04:49:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1738471750; x=1770007750; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=5wKm0aYw5LMzGFRHPLrYDtn9SZNot9Fk2U7Cck0hqJ0=; b=t/GvjKzMfJTcz6me0KQmHGdR5yks+RUjDFkvI2zq66DgYFZqkpNctCN6 HyBUWwJk2Vxt/FZiaGl1Q2RGoU114TDSC0RI/0jOnV5kzLci6bQcDjz2u 3irO4KVdj6Y/wcF7F8DorFRPfFMNurMPcIck7vUDmEJJq/5YO1rnOvMWb s=; X-IronPort-AV: E=Sophos;i="6.13,253,1732579200"; d="scan'208";a="795416663" Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.25.36.210]) by smtp-border-fw-9106.sea19.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2025 04:33:10 +0000 Received: from EX19MTAUWA002.ant.amazon.com [10.0.21.151:61079] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.14.41:2525] with esmtp (Farcaster) id c97bc524-8d2f-4380-8fcd-c91536b085e0; Sun, 2 Feb 2025 04:33:10 +0000 (UTC) X-Farcaster-Flow-ID: c97bc524-8d2f-4380-8fcd-c91536b085e0 Received: from EX19D003ANC003.ant.amazon.com (10.37.240.197) by EX19MTAUWA002.ant.amazon.com (10.250.64.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.39; Sun, 2 Feb 2025 04:33:07 +0000 Received: from b0be8375a521.amazon.com (10.37.244.8) by EX19D003ANC003.ant.amazon.com (10.37.240.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.39; Sun, 2 Feb 2025 04:33:03 +0000 To: , Date: Sun, 2 Feb 2025 13:32:53 +0900 Message-ID: <20250202043253.64389-1-enjuk@amazon.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) MIME-Version: 1.0 X-Originating-IP: [10.37.244.8] X-ClientProxiedBy: EX19D046UWA003.ant.amazon.com (10.13.139.18) To EX19D003ANC003.ant.amazon.com (10.37.240.197) X-Headers-End: 1teRuw-00077F-5v Subject: [f2fs-dev] [PATCH v1] f2fs: remove unnecessary null checking X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Kohei Enju via Linux-f2fs-devel From: Kohei Enju Reply-To: Kohei Enju Cc: Jens Axboe , Damien Le Moal , Chaitanya Kulkarni , Johannes Thumshirn , Jaegeuk Kim , Kohei Enju , Kohei Enju Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net When __GFP_DIRECT_RECLAIM (included in both GFP_NOIO and GFP_KERNEL) is specified, bio_alloc_bioset() never fails to allocate a bio. Commit 67883ade7a98 ("f2fs: remove FAULT_ALLOC_BIO") replaced f2fs_bio_alloc() with bio_alloc_bioset(), but null checking after bio_alloc_bioset() was still left. Fixes: 67883ade7a98 ("f2fs: remove FAULT_ALLOC_BIO") Signed-off-by: Kohei Enju Reviewed-by: Jens Axboe --- fs/f2fs/data.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index de4da6d9cd93..07b46b444d31 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -1041,8 +1041,6 @@ static struct bio *f2fs_grab_read_bio(struct inode *inode, block_t blkaddr, bio = bio_alloc_bioset(bdev, bio_max_segs(nr_pages), REQ_OP_READ | op_flag, for_write ? GFP_NOIO : GFP_KERNEL, &f2fs_bioset); - if (!bio) - return ERR_PTR(-ENOMEM); bio->bi_iter.bi_sector = sector; f2fs_set_bio_crypt_ctx(bio, inode, first_idx, NULL, GFP_NOFS); bio->bi_end_io = f2fs_read_end_io;