diff mbox series

[02/26] cred: return old creds from revert_creds_light()

Message ID	20241124-work-cred-v1-2-f352241c3970@kernel.org
State	Superseded
Headers	show Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CBA7204F89; Sun, 24 Nov 2024 13:44:20 +0000 (UTC) From: Christian Brauner <brauner@kernel.org> To: Linus Torvalds <torvalds@linux-foundation.org> Cc: Christian Brauner <brauner@kernel.org>, Amir Goldstein <amir73il@gmail.com>, Miklos Szeredi <miklos@szeredi.hu>, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH 02/26] cred: return old creds from revert_creds_light() Date: Sun, 24 Nov 2024 14:43:48 +0100 Message-ID: <20241124-work-cred-v1-2-f352241c3970@kernel.org> In-Reply-To: <20241124-work-cred-v1-0-f352241c3970@kernel.org> References: <20241124-work-cred-v1-0-f352241c3970@kernel.org> Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit
Series	cred: rework {override,revert}_creds() \| expand [00/26] cred: rework {override,revert}_creds() [01/26] tree-wide: s/override_creds()/override_creds_light(get_new_cred())/g [02/26] cred: return old creds from revert_creds_light() [03/26] tree-wide: s/revert_creds()/put_cred(revert_creds_light())/g [04/26] cred: remove old {override,revert}_creds() helpers [05/26] tree-wide: s/override_creds_light()/override_creds()/g [06/26] tree-wide: s/revert_creds_light()/revert_creds()/g [07/26] firmware: avoid pointless reference count bump [08/26] sev-dev: avoid pointless cred reference count bump [09/26] target_core_configfs: avoid pointless cred reference count bump [10/26] aio: avoid pointless cred reference count bump [11/26] binfmt_misc: avoid pointless cred reference count bump [12/26] coredump: avoid pointless cred reference count bump [13/26] nfs/localio: avoid pointless cred reference count bumps [14/26] nfs/nfs4idmap: avoid pointless reference count bump [15/26] nfs/nfs4recover: avoid pointless cred reference count bump [16/26] nfsfh: avoid pointless cred reference count bump [17/26] open: avoid pointless cred reference count bump [18/26] ovl: avoid pointless cred reference count bump [19/26] cifs: avoid pointless cred reference count bump [20/26] cifs: avoid pointless cred reference count bump [21/26] smb: avoid pointless cred reference count bump [22/26] io_uring: avoid pointless cred reference count bump [23/26] acct: avoid pointless reference count bump [24/26] cgroup: avoid pointless cred reference count bump [25/26] trace: avoid pointless cred reference count bump [26/26] dns_resolver: avoid pointless cred reference count bump

Commit Message

Christian Brauner Nov. 24, 2024, 1:43 p.m. UTC

So we can easily convert revert_creds() callers over to drop the
reference count explicitly.

Signed-off-by: Christian Brauner <brauner@kernel.org>
---
 include/linux/cred.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/include/linux/cred.h b/include/linux/cred.h
index e4a3155fe409d6b991fa6639005ebc233fc17dcc..382768a9707b5c3e6cbd3e8183769e1227a73107 100644
--- a/include/linux/cred.h
+++ b/include/linux/cred.h
@@ -185,9 +185,12 @@  static inline const struct cred *override_creds_light(const struct cred *overrid
 	return old;
 }
 
-static inline void revert_creds_light(const struct cred *revert_cred)
+static inline const struct cred *revert_creds_light(const struct cred *revert_cred)
 {
+	const struct cred *override_cred = current->cred;
+
 	rcu_assign_pointer(current->cred, revert_cred);
+	return override_cred;
 }
 
 /**