| Message ID | 20241124-work-cred-v1-8-f352241c3970@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | cred: rework {override,revert}_creds() | expand |
On Sun, Nov 24, 2024 at 02:43:54PM +0100, Christian Brauner wrote: > drivers/crypto/ccp/sev-dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c > index 187c34b02442dd50640f88713bc5f6f88a1990f4..2e87ca0e292a1c1706a8e878285159b481b68a6f 100644 > --- a/drivers/crypto/ccp/sev-dev.c > +++ b/drivers/crypto/ccp/sev-dev.c > @@ -244,7 +244,7 @@ static struct file *open_file_as_root(const char *filename, int flags, umode_t m > if (!cred) > return ERR_PTR(-ENOMEM); > cred->fsuid = GLOBAL_ROOT_UID; > - old_cred = override_creds(get_new_cred(cred)); > + old_cred = override_creds(cred); > > fp = file_open_root(&root, filename, flags, mode); > path_put(&root); Looks sane, but the use of file reads/writes in there does not. At the very least, this nwrite = kernel_write(fp, sev_init_ex_buffer, NV_LENGTH, &offset); vfs_fsync(fp, 0); filp_close(fp, NULL); if (nwrite != NV_LENGTH) { dev_err(sev->dev, "SEV: failed to write %u bytes to non volatile memory area, ret %ld\n", NV_LENGTH, nwrite); return -EIO; } is either too much or too little - if it's serious about reporting errors, it would better check what fsync and close return... Oh, well - unrelated to your patchset, obviously
diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c index 187c34b02442dd50640f88713bc5f6f88a1990f4..2e87ca0e292a1c1706a8e878285159b481b68a6f 100644 --- a/drivers/crypto/ccp/sev-dev.c +++ b/drivers/crypto/ccp/sev-dev.c @@ -244,7 +244,7 @@ static struct file *open_file_as_root(const char *filename, int flags, umode_t m if (!cred) return ERR_PTR(-ENOMEM); cred->fsuid = GLOBAL_ROOT_UID; - old_cred = override_creds(get_new_cred(cred)); + old_cred = override_creds(cred); fp = file_open_root(&root, filename, flags, mode); path_put(&root);
and fix a memory leak while at it. The new creds are created via prepare_creds() and then reverted via put_cred(revert_creds()). The additional reference count bump from override_creds() wasn't even taken into account before. Signed-off-by: Christian Brauner <brauner@kernel.org> --- drivers/crypto/ccp/sev-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)