From patchwork Mon Aug 27 18:29:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 10577459 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 324FC5A4 for ; Mon, 27 Aug 2018 18:27:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2000E29D87 for ; Mon, 27 Aug 2018 18:27:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1364229E1A; Mon, 27 Aug 2018 18:27:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_SBL_CSS autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B5B1529D87 for ; Mon, 27 Aug 2018 18:27:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727401AbeH0WPT (ORCPT ); Mon, 27 Aug 2018 18:15:19 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:44165 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726895AbeH0WPT (ORCPT ); Mon, 27 Aug 2018 18:15:19 -0400 Received: by mail-wr1-f67.google.com with SMTP id v16-v6so14511098wro.11; Mon, 27 Aug 2018 11:27:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=s8ywewpLvRruExKA1l43Q+dgdcYXnA+BV9sX3rJmm4Y=; b=IZChyzrwmuqXwcVA4st0cXiNuWabci7kzZFuPz1yMnj4xuOFsX34Ae2zJsKlisrd2J BdCsojUQ6ZZVnV1pvj/1gekjCsIkko2Yc9at9kpJvwI2FcauBlGGTdRu7oiZ+lEhiv/h RXMLz6Ue9eD2PC3Sbgn+zmOOhfcmDV9psJCWaJQIxXIJmBXrFVYceKg+MF3pilvhSq2Z MWJwN60sPRjIkZW+HJwJqdlGKLHWeI3ilKnQHlybANtCB13TFoFpWdUo358H6z/YOZr0 91w+BfyNs4VF7xtb5foXJqywVHQV9I0Ro7/NKpQXKkjdlbleKUjuiyLjFhiwisbX6/zp vbrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=s8ywewpLvRruExKA1l43Q+dgdcYXnA+BV9sX3rJmm4Y=; b=SYWf/xZnwWYgnkPZh1XmwKcQu5GNPb9UC4iumQKVDPD+CPTCXT6npFah7Q+t7H6Q4R F9XnlL8gJjcZtKTmP9lEDXNGk5Th6lezvZH4ey5tvsDWMleOZylYRzfehz9TXn+Mk3+3 v2aJkqx66L/n+dq2tNU88fN7jk0qKIsQU/yYIzruu8GkOO+IpPR142MxNZWapaS86TEY Bxd1s5yEVt89VAiajxjHyMt9HgYntU1BLgXYvWK6ttFRMn0zWrAOSI8KWsKbOiI5DwsM Hpbt71r/Msgn3G6H74hxPmyRvGCsF3MUJoOp7+4bOOt3/bsmV3FymT4uut8FeQgvotSM k8MQ== X-Gm-Message-State: APzg51C+Q+GMlhPbCeNOkl8yeNWcZonoBK4Uwf7wUbN7Nt+xAVLLZ1oT Brh+wK8GWHiwDWdkwRVJg20= X-Google-Smtp-Source: ANB0VdYOLI++oA02DfBEMtOAgd2Dgw5c8GwpvMEboA+HwMhKMHCpcXDH1hznKhoIJKKwuIqrYUFmvQ== X-Received: by 2002:a5d:5685:: with SMTP id f5-v6mr9826355wrv.58.1535394455515; Mon, 27 Aug 2018 11:27:35 -0700 (PDT) Received: from localhost.localdomain ([141.226.8.68]) by smtp.gmail.com with ESMTPSA id r66-v6sm4658211wmb.37.2018.08.27.11.27.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 27 Aug 2018 11:27:34 -0700 (PDT) From: Amir Goldstein To: Eryu Guan Cc: Theodore Ts'o , fstests@vger.kernel.org, linux-ext4@vger.kernel.org, linux-unionfs@vger.kernel.org Subject: [PATCH 0/2] fstests: fix overlay test failure over ext4 Date: Mon, 27 Aug 2018 21:29:24 +0300 Message-Id: <1535394566-18837-1-git-send-email-amir73il@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Eryu, As I reported earlier, test generic/009 was failing ./check -overlay run due to a test bug. The test belongs to a class of tests that have explicit check for a certain $FSTYP, which does not apply when FSTYP is overlay. I ran all the tests that check for FSTYP = ext4 with overlay over ext4 and all the tests that check for FSTYP = xfs with overlay over xfs. generic/009 was the only test that failed because of the exlicit check. The rest of the tests either passes or did not run for a good reason. Strangely, tests which _require_seek_data_hole(), that has the exact same check as generic/009 didn't fail with overlay over ext4. In fact, those tests also did not with with bare ext4 even when I removed the call to _ext4_disable_extent_zeroout() from _require_seek_data_hole()??? I tried to come up with a more generic solution, but didn't like any ideas I had, so I ended up fixing generic/009 in place in the hope that you either accept it as is or propose a better solution. The fix depends on the user either setting FSTYP=ext4 in a config file or setting the variable OVL_BASE_FSTYP before running the test. I will soon send a patch for kvm-xfstests to Ted that does the latter. Thanks, Amir. Amir Goldstein (2): overlay: do not set OVL_BASE_FSTYP value to "overlay" generic/009: fix test failure with overlay over ext4 common/config | 2 +- tests/generic/009 | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-)