[v2,0/5] Tests for overlayfs immutable/append-only files

Message

Amir Goldstein Feb. 10, 2021, 7:03 p.m. UTC

Eryu,

Overlayfs never had full support for immutable/append-only files.
Whatever works is covered by generic/079 and overlay/030 tests.
Both tests cover only upper files and directories.
generic/079 is notrun on kernel < 5.10 and passes on >= 5.10.

This series improves the t_immutable test program and adds two new
tests.

overlay/075 tests immutable/append-only lower files and directories -
the test fails on upstream kernel.  Fixing this requires some VFS API
changes that Miklos has proposed [1].

overlay/076 is a "dangerous" test that triggers a deadlock.
The deadlock was fixed in master and in stable kernel v5.10.15.

Thanks,
Amir. 

Changes since v1:
- Split the dangerous test
- Document fix commit
- Fix Eryu's minor review comments on t_immutable

[1] https://lore.kernel.org/linux-fsdevel/[e-mail]/

Amir Goldstein (5):
  overlay/030: Update comment w.r.t upstream kernel
  src/t_immutable: factor out some helpers
  src/t_immutable: Allow setting flags on existing files
  overlay: Test lost immutable/append-only flags on copy-up
  overlay: Regression test for deadlock on directory ioctl

 src/t_immutable.c     | 241 +++++++++++++++++++++---------------------
 tests/overlay/030     |   7 +-
 tests/overlay/075     |  92 ++++++++++++++++
 tests/overlay/075.out |  11 ++
 tests/overlay/076     |  66 ++++++++++++
 tests/overlay/076.out |   2 +
 tests/overlay/group   |   2 +
 7 files changed, 301 insertions(+), 120 deletions(-)
 create mode 100755 tests/overlay/075
 create mode 100644 tests/overlay/075.out
 create mode 100644 tests/overlay/076
 create mode 100644 tests/overlay/076.out