[v4,0/2] group ownership changing test

Message

Zorro Lang Sept. 20, 2022, 11:50 a.m. UTC

Hi Christian,

It's been 3 month past, since your patch [1] was reviewed last time. I'm still
waititng for this test coverage for fs. According to the review points last
time, I split your v3 patch [1] to 2 separated cases, one basic testing for
covering that fix, one extend testing for overlay part.

I only did below changes (compare with v3):
1) Split one case to two cases.
2) Move "_supports_filetype" line under the _scratch_mount.

I still keep the patch Author as you, and signed-off-by you, due to I just
hope to bring this discussion back, and push the proceeding of this patch
be merged.

(CC the old cc list to get more review)

Thanks,
Zorro

[1]
https://lore.kernel.org/fstests/[e-mail]/

Comments

Christian Brauner Sept. 20, 2022, 2:50 p.m. UTC | #1

On Tue, Sep 20, 2022 at 07:50:33PM +0800, Zorro Lang wrote:
> Hi Christian,
> 
> It's been 3 month past, since your patch [1] was reviewed last time. I'm still
> waititng for this test coverage for fs. According to the review points last
> time, I split your v3 patch [1] to 2 separated cases, one basic testing for
> covering that fix, one extend testing for overlay part.
> 
> I only did below changes (compare with v3):
> 1) Split one case to two cases.
> 2) Move "_supports_filetype" line under the _scratch_mount.
> 
> I still keep the patch Author as you, and signed-off-by you, due to I just
> hope to bring this discussion back, and push the proceeding of this patch
> be merged.
> 
> (CC the old cc list to get more review)
> 
> Thanks,
> Zorro
> 
> [1]
> https://lore.kernel.org/fstests/[e-mail]/

Zorro,

Thank you for picking this patchset up! I just didn't have the time.
I've applied it, reviewed, and tested it:

Reviewed-by: Christian Brauner (Microsoft) <[e-mail]>
Tested-by: Christian Brauner (Microsoft) <[e-mail]>

We really need this regression test!

Christian

Zorro Lang Sept. 20, 2022, 3:11 p.m. UTC | #2

On Tue, Sep 20, 2022 at 04:50:06PM +0200, Christian Brauner wrote:
> On Tue, Sep 20, 2022 at 07:50:33PM +0800, Zorro Lang wrote:
> > Hi Christian,
> > 
> > It's been 3 month past, since your patch [1] was reviewed last time. I'm still
> > waititng for this test coverage for fs. According to the review points last
> > time, I split your v3 patch [1] to 2 separated cases, one basic testing for
> > covering that fix, one extend testing for overlay part.
> > 
> > I only did below changes (compare with v3):
> > 1) Split one case to two cases.
> > 2) Move "_supports_filetype" line under the _scratch_mount.
> > 
> > I still keep the patch Author as you, and signed-off-by you, due to I just
> > hope to bring this discussion back, and push the proceeding of this patch
> > be merged.
> > 
> > (CC the old cc list to get more review)
> > 
> > Thanks,
> > Zorro
> > 
> > [1]
> > https://lore.kernel.org/fstests/[e-mail]/
> 
> Zorro,
> 
> Thank you for picking this patchset up! I just didn't have the time.
> I've applied it, reviewed, and tested it:
> 
> Reviewed-by: Christian Brauner (Microsoft) <[e-mail]>
> Tested-by: Christian Brauner (Microsoft) <[e-mail]>
> 
> We really need this regression test!

Np, I'd like to have this testing coverage too, so I keep it in my queueing list
long time. I'd like to add your RVB, but it's weird to be reviewed by yourself,
due to I keep the author and signed-off-by to you :) And this patchset is sent
by me now, so it might be weird too if I ack it :-D

Anyway, if there's no objection or more review points from others, I'd like to
merge this patchset (signed-off-by you, reviewed by me) this week.

Thanks,
Zorro

> 
> Christian
>