[v2,0/4] Overlayfs tests for 6.7-rc1

Message

Amir Goldstein Dec. 4, 2023, 6:58 p.m. UTC

Zorro,

This update contains 3 new overlayfs tests for new features added
in v6.7-rc1.

overlay/084, written by Alexander, tests the new nested xattrs feature.
overlay/{085,086} test the new lowerdir+,datadir+ mount options.

overlay/086 was partly forked from overlay/083, but overlay/083 is not
sensitive to libmount version, because the escaped commas test is not
related to any specific mount option, so it wasn't copied over.

All the new tests do not run on older kernels.

Thanks,
Amir.

Changed since v1:
- Helper _require_scratch_overlay_xattr_escapes() already added by
  "overlay/026: Fix test expectation for newer kernels"

Amir Goldstein (4):
  overlay: Add tests for nesting private xattrs
  overlay: prepare for new lowerdir+,datadir+ tests
  overlay: test data-only lowerdirs with datadir+ mount option
  overlay: test parsing of lowerdir+,datadir+ mount options

 common/overlay        |  15 ++
 tests/overlay/079     |  36 +++--
 tests/overlay/084     | 169 +++++++++++++++++++++
 tests/overlay/084.out |  61 ++++++++
 tests/overlay/085     | 332 ++++++++++++++++++++++++++++++++++++++++++
 tests/overlay/085.out |  42 ++++++
 tests/overlay/086     |  81 +++++++++++
 tests/overlay/086.out |   2 +
 8 files changed, 723 insertions(+), 15 deletions(-)
 create mode 100755 tests/overlay/084
 create mode 100644 tests/overlay/084.out
 create mode 100755 tests/overlay/085
 create mode 100644 tests/overlay/085.out
 create mode 100755 tests/overlay/086
 create mode 100644 tests/overlay/086.out

Comments

Zorro Lang Dec. 9, 2023, 4:49 a.m. UTC | #1

On Mon, Dec 04, 2023 at 08:58:55PM +0200, Amir Goldstein wrote:
> Zorro,
> 
> This update contains 3 new overlayfs tests for new features added
> in v6.7-rc1.
> 
> overlay/084, written by Alexander, tests the new nested xattrs feature.
> overlay/{085,086} test the new lowerdir+,datadir+ mount options.
> 
> overlay/086 was partly forked from overlay/083, but overlay/083 is not
> sensitive to libmount version, because the escaped commas test is not
> related to any specific mount option, so it wasn't copied over.
> 
> All the new tests do not run on older kernels.
> 
> Thanks,
> Amir.
> 
> Changed since v1:
> - Helper _require_scratch_overlay_xattr_escapes() already added by
>   "overlay/026: Fix test expectation for newer kernels"

This version looks good to me, let's have this feature test coverage
at first.

Reviewed-by: Zorro Lang <[e-mail]>

> 
> Amir Goldstein (4):
>   overlay: Add tests for nesting private xattrs
>   overlay: prepare for new lowerdir+,datadir+ tests
>   overlay: test data-only lowerdirs with datadir+ mount option
>   overlay: test parsing of lowerdir+,datadir+ mount options
> 
>  common/overlay        |  15 ++
>  tests/overlay/079     |  36 +++--
>  tests/overlay/084     | 169 +++++++++++++++++++++
>  tests/overlay/084.out |  61 ++++++++
>  tests/overlay/085     | 332 ++++++++++++++++++++++++++++++++++++++++++
>  tests/overlay/085.out |  42 ++++++
>  tests/overlay/086     |  81 +++++++++++
>  tests/overlay/086.out |   2 +
>  8 files changed, 723 insertions(+), 15 deletions(-)
>  create mode 100755 tests/overlay/084
>  create mode 100644 tests/overlay/084.out
>  create mode 100755 tests/overlay/085
>  create mode 100644 tests/overlay/085.out
>  create mode 100755 tests/overlay/086
>  create mode 100644 tests/overlay/086.out
> 
> -- 
> 2.34.1
>