| Message ID | cover.1743487913.git.nirjhar.roy.lists@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Minor cleanups in common/ | expand |
On Tue, Apr 01, 2025 at 06:43:55AM +0000, Nirjhar Roy (IBM) wrote: > This patch series removes some unnecessary sourcing of common/rc > and decouples the call to init_rc() from the sourcing of common/rc. > This is proposed in [1] and [2]. It also removes direct usage of exit command > with a _exit wrapper. The individual patches have the details. > > [v1] --> v[2] > 1. Added R.B from Darrick in patch 1 of [v1] > 2. Kept the init_rc call that was deleted in the v1. > 3. Introduced _exit wrapper around exit command. This will help us get correct > exit codes ("$?") on failures. > > [1] https://lore.kernel.org/all/20250206155251.GA21787@frogsfrogsfrogs/ > > [2] https://lore.kernel.org/all/20250210142322.tptpphdntglsz4eq@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com/ > > [v1] https://lore.kernel.org/all/cover.1741248214.git.nirjhar.roy.lists@gmail.com/ > > Nirjhar Roy (IBM) (5): > generic/749: Remove redundant sourcing of common/rc > check: Remove redundant _test_mount in check > check,common{rc,preamble}: Decouple init_rc() call from sourcing > common/rc > common/config: Introduce _exit wrapper around exit command > common: exit --> _exit Whole series looks fine to me. I've got similar patches in my current check-parallel stack, as well as changing common/config to match the "don't run setup code when sourcing the file" behaviour. Reviewed-by: Dave Chinner <dchinner@redhat.com>
This patch series removes some unnecessary sourcing of common/rc and decouples the call to init_rc() from the sourcing of common/rc. This is proposed in [1] and [2]. It also removes direct usage of exit command with a _exit wrapper. The individual patches have the details. [v1] --> v[2] 1. Added R.B from Darrick in patch 1 of [v1] 2. Kept the init_rc call that was deleted in the v1. 3. Introduced _exit wrapper around exit command. This will help us get correct exit codes ("$?") on failures. [1] https://lore.kernel.org/all/20250206155251.GA21787@frogsfrogsfrogs/ [2] https://lore.kernel.org/all/20250210142322.tptpphdntglsz4eq@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com/ [v1] https://lore.kernel.org/all/cover.1741248214.git.nirjhar.roy.lists@gmail.com/ Nirjhar Roy (IBM) (5): generic/749: Remove redundant sourcing of common/rc check: Remove redundant _test_mount in check check,common{rc,preamble}: Decouple init_rc() call from sourcing common/rc common/config: Introduce _exit wrapper around exit command common: exit --> _exit check | 8 +--- common/btrfs | 6 +-- common/ceph | 2 +- common/config | 15 +++++-- common/ext4 | 2 +- common/populate | 2 +- common/preamble | 3 +- common/punch | 12 +++--- common/rc | 105 ++++++++++++++++++++++------------------------ common/xfs | 8 ++-- tests/generic/749 | 1 - 11 files changed, 81 insertions(+), 83 deletions(-) -- 2.34.1