diff mbox

[1/8,v4] common/rc: add _require_scratch_shtudown

Message ID 1423004840-45315-2-git-send-email-jaegeuk@kernel.org (mailing list archive)
State New, archived
Headers show

Commit Message

Jaegeuk Kim Feb. 3, 2015, 11:07 p.m. UTC 
This is to detect whether filesystem supports shutdown feature or not.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 common/rc | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Dave Chinner Feb. 5, 2015, 2:01 a.m. UTC | #1 
On Tue, Feb 03, 2015 at 03:07:13PM -0800, Jaegeuk Kim wrote:
> This is to detect whether filesystem supports shutdown feature or not.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>  common/rc | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/common/rc b/common/rc
> index 5377ba0..438cd51 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2320,6 +2320,17 @@ _require_freeze()
>  	[ $result -eq 0 ] || _notrun "$FSTYP does not support freezing"
>  }
>  
> +# Does shutdown work on this fs?
> +_require_scratch_shutdown()
> +{
> +	[ -x src/godown ] || _notrun "src/godown executable not found"
> +
> +        _scratch_mount

Whitespace damage. Also, the state of the scratch device is
undefined until scratch_mkfs is run.

> +	src/godown -v -f $SCRATCH_MNT >/dev/null 2>&1 \
> +		|| _notrun "$FSTYP does not support shutdown"

Why verbose if you are redirecting all output to /dev/null?

> +	_scratch_unmount
> +}

Cheers,

Dave.
diff mbox

Patch

diff --git a/common/rc b/common/rc
index 5377ba0..438cd51 100644
--- a/common/rc
+++ b/common/rc
@@ -2320,6 +2320,17 @@  _require_freeze()
 	[ $result -eq 0 ] || _notrun "$FSTYP does not support freezing"
 }
 
+# Does shutdown work on this fs?
+_require_scratch_shutdown()
+{
+	[ -x src/godown ] || _notrun "src/godown executable not found"
+
+        _scratch_mount
+	src/godown -v -f $SCRATCH_MNT >/dev/null 2>&1 \
+		|| _notrun "$FSTYP does not support shutdown"
+	_scratch_unmount
+}
+
 # arg 1 is dev to remove and is output of the below eg.
 # ls -l /sys/class/block/sdd | rev | cut -d "/" -f 3 | rev
 _devmgt_remove()