From patchwork Fri Apr 3 07:18:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eryu Guan X-Patchwork-Id: 6153931 Return-Path: X-Original-To: patchwork-fstests@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 7806E9F398 for ; Fri, 3 Apr 2015 07:18:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 84098203B6 for ; Fri, 3 Apr 2015 07:18:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ADED12035B for ; Fri, 3 Apr 2015 07:18:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752400AbbDCHSV (ORCPT ); Fri, 3 Apr 2015 03:18:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56967 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752384AbbDCHSU (ORCPT ); Fri, 3 Apr 2015 03:18:20 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t337IKqu018138 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 3 Apr 2015 03:18:20 -0400 Received: from localhost (dhcp-12-136.nay.redhat.com [10.66.12.136]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t337IIqM003634; Fri, 3 Apr 2015 03:18:19 -0400 From: Eryu Guan To: fstests@vger.kernel.org Cc: linux-ext4@vger.kernel.org, Eryu Guan , Lukas Czerner Subject: [PATCH v2 3/4] shared: test truncate orphan inodes when mounting extN Date: Fri, 3 Apr 2015 15:18:02 +0800 Message-Id: <1428045482-10722-1-git-send-email-eguan@redhat.com> In-Reply-To: <1428045351-10446-1-git-send-email-eguan@redhat.com> References: <1428045351-10446-1-git-send-email-eguan@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP ext4 should hold i_mutex when truncating orhpan inodes, or a WARNING would be triggered. This commit fixed this issue. 721e3eb ext4: lock i_mutex when truncating orphan inodes Though it's an ext4 specific issue, there's no harm to test on ext2/3 too, as debugfs is used to set orphan inode list. This test is based on a script from Lukas Czerner. Cc: Lukas Czerner Signed-off-by: Eryu Guan --- v2: - fix wrong seq number at the beginning of the test tests/shared/001 | 71 ++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/shared/001.out | 2 ++ tests/shared/group | 1 + 3 files changed, 74 insertions(+) create mode 100755 tests/shared/001 create mode 100644 tests/shared/001.out diff --git a/tests/shared/001 b/tests/shared/001 new file mode 100755 index 0000000..49991fd --- /dev/null +++ b/tests/shared/001 @@ -0,0 +1,71 @@ +#! /bin/bash +# FS QA Test No. 001 +# +# Test truncate orphan inodes when mounting extN. +# ext4 used to hit WARNING, this commit fixed the issue +# +# 721e3eb ext4: lock i_mutex when truncating orphan inodes +# +#----------------------------------------------------------------------- +# Copyright (c) 2015 Red Hat Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs ext2 ext3 ext4 +_supported_os Linux +_require_scratch + +rm -f $seqres.full +echo "Silence is golden" + +_scratch_mkfs_sized $((16*1024*1024)) >>$seqres.full 2>&1 +_scratch_mount + +# create a file and get its inode number, usually it's 12, but to be accurate +testfile=$SCRATCH_MNT/testfile +touch $testfile +inode=`ls -i $testfile | awk '{print $1}'` + +# add the inode in orphan inode list +_scratch_unmount +debugfs -w -R "set_super_value last_orphan $inode" $SCRATCH_DEV \ + >>$seqres.full 2>&1 + +# mount again to truncate orphan inode, _check_dmesg will catch the WARNING +_scratch_mount + +status=0 +exit diff --git a/tests/shared/001.out b/tests/shared/001.out new file mode 100644 index 0000000..88678b8 --- /dev/null +++ b/tests/shared/001.out @@ -0,0 +1,2 @@ +QA output created by 001 +Silence is golden diff --git a/tests/shared/group b/tests/shared/group index 429f2b4..0134f81 100644 --- a/tests/shared/group +++ b/tests/shared/group @@ -3,6 +3,7 @@ # - do not start group names with a digit # - comment line before each group is "new" description # +001 auto quick 006 auto enospc 032 mkfs auto quick 051 acl udf auto quick