From patchwork Tue Apr 7 09:04:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qu Wenruo X-Patchwork-Id: 6168161 Return-Path: X-Original-To: patchwork-fstests@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 70CF4BF4A6 for ; Tue, 7 Apr 2015 09:06:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EA13620364 for ; Tue, 7 Apr 2015 09:06:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8CF7D2034A for ; Tue, 7 Apr 2015 09:06:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753062AbbDGJGv (ORCPT ); Tue, 7 Apr 2015 05:06:51 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:8264 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752479AbbDGJGt (ORCPT ); Tue, 7 Apr 2015 05:06:49 -0400 X-IronPort-AV: E=Sophos;i="5.04,848,1406563200"; d="scan'208";a="90281547" Received: from localhost (HELO edo.cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 07 Apr 2015 17:03:00 +0800 Received: from G08CNEXCHPEKD02.g08.fujitsu.local (localhost.localdomain [127.0.0.1]) by edo.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id t3795e97029146; Tue, 7 Apr 2015 17:05:40 +0800 Received: from localhost.localdomain (10.167.226.33) by G08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.181.6; Tue, 7 Apr 2015 17:06:50 +0800 From: Qu Wenruo To: , Subject: [PATCH RESEND 1/2] fstests: btrfs/088: Check return value of "btrfs filesystem show" command executed on umounted device. Date: Tue, 7 Apr 2015 17:04:41 +0800 Message-ID: <1428397482-13658-1-git-send-email-quwenruo@cn.fujitsu.com> X-Mailer: git-send-email 2.3.5 MIME-Version: 1.0 X-Originating-IP: [10.167.226.33] Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The return value should always be 0 if no problem happens, but "btrfs filesystem show" executed on umounted device will always return 1 even there is no problem. This testcase just checks it. Signed-off-by: Qu Wenruo --- Rebased to latest fstests. 087 is taken by Filipe's test case "fstests: test for btrfs transaction abortion on device with discard support", so take 088. --- tests/btrfs/088 | 71 +++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/088.out | 2 ++ tests/btrfs/group | 1 + 3 files changed, 74 insertions(+) create mode 100644 tests/btrfs/088 create mode 100644 tests/btrfs/088.out diff --git a/tests/btrfs/088 b/tests/btrfs/088 new file mode 100644 index 0000000..768d2bf --- /dev/null +++ b/tests/btrfs/088 @@ -0,0 +1,71 @@ +#! /bin/bash +# FS QA Test No. btrfs/088 +# +# Check return value of "btrfs filesystem show" command executed on +# umounted device. +# It should return 0 if nothing wrong happens. +# +# Regression in v3.18 btrfs-progs and fixed by the following patch: +# +# btrfs-progs: Fix wrong return value when executing 'fi show' on +# umounted device. +# +#----------------------------------------------------------------------- +# Copyright (c) 2015 Fujitsu, Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter.btrfs + +# real QA test starts here + +# Modify as appropriate. +_supported_fs btrfs +_supported_os Linux +_require_scratch +_require_scratch_dev_pool + +rm -f $seqres.full + +FIRST_POOL_DEV=`echo $SCRATCH_DEV_POOL | awk '{print $1}'` +TOTAL_DEVS=`echo $SCRATCH_DEV_POOL | wc -w` + +_scratch_pool_mkfs >> $seqres.full 2>&1 || _fail "mkfs failed" + +_run_btrfs_util_prog filesystem show $FIRST_POOL_DEV | \ + _filter_btrfs_filesystem_show $TOTAL_DEVS + +# success, all done +echo "Silence is golden" +status=0 +exit diff --git a/tests/btrfs/088.out b/tests/btrfs/088.out new file mode 100644 index 0000000..c24480a --- /dev/null +++ b/tests/btrfs/088.out @@ -0,0 +1,2 @@ +QA output created by 088 +Silence is golden diff --git a/tests/btrfs/group b/tests/btrfs/group index e9c15af..a053d14 100644 --- a/tests/btrfs/group +++ b/tests/btrfs/group @@ -89,3 +89,4 @@ 084 auto quick send 085 auto quick metadata subvol 086 auto quick clone +088 auto quick