| Message ID | 1437913255-7524-2-git-send-email-tytso@mit.edu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Jul 26, 2015 at 08:20:50AM -0400, Theodore Ts'o wrote: > Android's bionic libc doesn't define NBBY; this isn't a standard > define, and since all modern/sane platforms have 8 bits per byte, use > this as a default. > > Signed-off-by: Theodore Ts'o <tytso@mit.edu> This looks fine, but it'll clash with my patch that changes platform_defs.h so that it's not run through autoconfs m4 anymore. Otherwise: Reviewed-by: Christoph Hellwig <hch@lst.de> -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/platform_defs.h.in b/include/platform_defs.h.in index ac260bc..3e059af 100644 --- a/include/platform_defs.h.in +++ b/include/platform_defs.h.in @@ -178,4 +178,8 @@ typedef unsigned short umode_t; #define max(a,b) (((a)>(b))?(a):(b)) #endif +#ifndef NBBY +#define NBBY 8 +#endif + #endif /* __XFS_PLATFORM_DEFS_H__ */
Android's bionic libc doesn't define NBBY; this isn't a standard define, and since all modern/sane platforms have 8 bits per byte, use this as a default. Signed-off-by: Theodore Ts'o <tytso@mit.edu> --- include/platform_defs.h.in | 4 ++++ 1 file changed, 4 insertions(+)