From patchwork Tue May 10 02:32:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Murphy Zhou X-Patchwork-Id: 9053101 Return-Path: X-Original-To: patchwork-fstests@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 805529F30C for ; Tue, 10 May 2016 02:33:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 909A120114 for ; Tue, 10 May 2016 02:32:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71B4E2012B for ; Tue, 10 May 2016 02:32:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753248AbcEJCc5 (ORCPT ); Mon, 9 May 2016 22:32:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42771 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753211AbcEJCc5 (ORCPT ); Mon, 9 May 2016 22:32:57 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AB74D8F516 for ; Tue, 10 May 2016 02:32:56 +0000 (UTC) Received: from localhost (dhcp-12-114.nay.redhat.com [10.66.12.114]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4A2WtJ0027431; Mon, 9 May 2016 22:32:56 -0400 From: Xiong Zhou To: fstests@vger.kernel.org Cc: eguan@redhat.com, Xiong Zhou Subject: [PATCH v2] overlay: test memleak in copy-up error handling path Date: Tue, 10 May 2016 10:32:45 +0800 Message-Id: <1462847565-12108-1-git-send-email-xzhou@redhat.com> In-Reply-To: <1462767157-26966-1-git-send-email-xzhou@redhat.com> References: <1462767157-26966-1-git-send-email-xzhou@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 10 May 2016 02:32:56 +0000 (UTC) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This memleak leads to panic when unmount the underlying fs. Kernel commit ab79efab0 fixed this issue. Signed-off-by: Xiong Zhou --- Diff to v1: set up underlying fs in $SCRATCH_DEV instead of $SCRATCH_MNT xfs_io open test_file instead of src/writemod use little upper dir to trigger ENOSP failure instead of kill clean up in cleanup Thanks Eryu for reviewing! tests/overlay/005 | 112 ++++++++++++++++++++++++++++++++++++++++++++++++++ tests/overlay/005.out | 2 + tests/overlay/group | 1 + 3 files changed, 115 insertions(+) create mode 100755 tests/overlay/005 create mode 100644 tests/overlay/005.out diff --git a/tests/overlay/005 b/tests/overlay/005 new file mode 100755 index 0000000..3816bf1 --- /dev/null +++ b/tests/overlay/005 @@ -0,0 +1,112 @@ +#! /bin/bash +# FS QA Test 005 +# +# Memleak in overlayfs copy-up error handling path leads to panic +# when unmount the underlying fs. +# Kernel commit ab79efab0 fixed this issue. +# +#----------------------------------------------------------------------- +# Copyright (c) 2016 Red Hat Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* + _destroy_loop_device $fs_loop_dev + _destroy_loop_device $upper_loop_dev + rm -f $fs_img + rm -f $upper_img +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +# Modify as appropriate. +_supported_fs overlay +_supported_os Linux +_require_scratch +_require_loop + +# setup loop images fs for overlayfs +fs_img=${SCRATCH_DEV}/${seq}.$$.img +$XFS_IO_PROG -f -c "truncate 120m" $fs_img >>$seqres.full 2>&1 +fs_loop_dev=`_create_loop_device $fs_img` +$MKFS_XFS_PROG -f -n ftype=1 $fs_loop_dev >>$seqres.full 2>&1 + +# only 20m for upper dir +upper_img=${SCRATCH_DEV}/$$.${seq}.img +$XFS_IO_PROG -f -c "truncate 20m" $upper_img >>$seqres.full 2>&1 +upper_loop_dev=`_create_loop_device $upper_img` +$MKFS_XFS_PROG -f -n ftype=1 $upper_loop_dev >>$seqres.full 2>&1 + +# mount underlying xfs +mkdir -p ${SCRATCH_DEV}/xfsmnt +mkdir -p ${SCRATCH_DEV}/uppermnt +$MOUNT_PROG $fs_loop_dev ${SCRATCH_DEV}/xfsmnt +$MOUNT_PROG $upper_loop_dev ${SCRATCH_DEV}/uppermnt + +# prepare dirs +mkdir -p ${SCRATCH_DEV}/xfsmnt/lower +mkdir -p ${SCRATCH_DEV}/uppermnt/upper +mkdir -p ${SCRATCH_DEV}/uppermnt/work + +lowerd=${SCRATCH_DEV}/xfsmnt/lower +upperd=${SCRATCH_DEV}/uppermnt/upper +workd=${SCRATCH_DEV}/uppermnt/work + +# Create test file in lower dir, with too big a size for +# upper dir to copy up. +$XFS_IO_PROG -f -c "truncate 48m" ${lowerd}/test_file \ + >>$seqres.full 2>&1 + +# mount new overlayfs +$MOUNT_PROG -t overlay $SELINUX_MOUNT_OPTIONS \ + -o lowerdir=$lowerd -o upperdir=$upperd \ + -o workdir=$workd \ + $SCRATCH_DEV $SCRATCH_MNT + +# the open call triggers copy-up and it will fail ENOSP +$XFS_IO_PROG -f -c "o" ${SCRATCH_MNT}/test_file \ + >>$seqres.full 2>&1 + +# unmount overlayfs +$UMOUNT_PROG $SCRATCH_MNT + +# unmount undelying xfs, this tiggers panic if memleak happens +$UMOUNT_PROG ${SCRATCH_DEV}/uppermnt +$UMOUNT_PROG ${SCRATCH_DEV}/xfsmnt + +# success, all done +echo "Silence is golden" +status=0 +exit diff --git a/tests/overlay/005.out b/tests/overlay/005.out new file mode 100644 index 0000000..a5027f1 --- /dev/null +++ b/tests/overlay/005.out @@ -0,0 +1,2 @@ +QA output created by 005 +Silence is golden diff --git a/tests/overlay/group b/tests/overlay/group index fcf6d63..bc2474e 100644 --- a/tests/overlay/group +++ b/tests/overlay/group @@ -7,3 +7,4 @@ 002 auto quick metadata 003 auto quick whiteout 004 attr auto copyup quick +005 auto copyup dangerous quick